From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759578AbYFFPaJ (ORCPT ); Fri, 6 Jun 2008 11:30:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755716AbYFFP34 (ORCPT ); Fri, 6 Jun 2008 11:29:56 -0400 Received: from correo3.acens.net ([217.116.0.35]:33779 "EHLO correo3.acens.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755635AbYFFP3z (ORCPT ); Fri, 6 Jun 2008 11:29:55 -0400 Message-ID: <484957E8.4020404@eslack.org> Date: Fri, 06 Jun 2008 17:29:44 +0200 From: Pau Oliva Fora User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Dmitry Torokhov CC: ?ric Piel , Jonathan Cameron , Jean Delvare , Andrew Morton , Burman , LKML , HWMON , "Mark M. Hoffman" , Pavel Machek , Yan@ATrpms.net, Dmitry@ATrpms.net, Arjan van de Ven Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! References: <1212235533.3815.5.camel@localhost> <4846EBF5.2030406@tremplin-utc.net> <20080604225830.1dff64fc@hyperion.delvare> <20080604230510.GB30475@elf.ucw.cz> <484728B2.1000209@tremplin-utc.net> <20080605082950.6957f1a2@hyperion.delvare> <4847B415.2080708@cam.ac.uk> <48484DD6.3050706@tremplin-utc.net> <4848683E.4070709@eslack.org> <20080606102237.ZZRA012@mailhub.coreip.homeip.net> In-Reply-To: <20080606102237.ZZRA012@mailhub.coreip.homeip.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry Torokhov wrote: > Hi, > > On Fri, Jun 06, 2008 at 12:27:10AM +0200, Pau Oliva Fora wrote: >> From: Pau Oliva Fora >> >> Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer. >> >> Signed-off-by: Pau Oliva Fora >> > > The input piece looks good, however it seens that the input is the > only functionality that this driver exports so I don't see any reason > to make input device registration optional. Or are you planning on > adding more functions to it? > I wasn't planning on adding more functions, I posted it so that Éric can have a look at the i2c part and integrate it in his driver. Pau Oliva