public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pau Oliva Fora <pau@eslack.org>
To: Eric Piel <E.A.B.Piel@tudelft.nl>
Cc: "Éric Piel" <Eric.Piel@tremplin-utc.net>,
	"Jonathan Cameron" <jic23@cam.ac.uk>,
	"Jean Delvare" <khali@linux-fr.org>,
	"Andrew Morton" <akpm@osdl.org>,
	Torokhov <dmitry.torokhov@gmail.com>,
	Burman <burman.yan@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	HWMON <lm-sensors@lm-sensors.org>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	"Pavel Machek" <pavel@suse.cz>,
	Yan@ATrpms.net, Dmitry@ATrpms.net,
	"Arjan van de Ven" <arjan@infradead.org>
Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!
Date: Fri, 06 Jun 2008 17:30:57 +0200	[thread overview]
Message-ID: <48495831.3050404@eslack.org> (raw)
In-Reply-To: <48495017.8040003@tudelft.nl>

Eric Piel wrote:
> Pau Oliva Fora wrote:
>> Here's an i2c version of the driver for the LIS3LV02DL accelerometer,
>> please try to combine it too, so we'll end up having ACPI, SPI and I2C.
> Whaoo, you went fast!
> As there is a dmi_match, that shouldn't be too hard to incorporate it 
> nicely :-)
> 
> BTW, do you really need the invert_x and invert_y and swap_xy 
> parameters? Don't all the HTC shift laptops have the sensors soldered 
> the same way? We've worked hard to remove those parameters in mdps ;-)
> 

Yes, you can remove the module params, and use the same approach you 
have based in DMI table.

Cheers,

	Pau Oliva

  reply	other threads:[~2008-06-06 15:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-31 12:05 [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Yan Burman
2008-06-04 19:24 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-04 20:58   ` Jean Delvare
2008-06-04 22:57     ` Éric Piel
2008-06-05  6:27       ` Jean Delvare
2008-06-04 23:05     ` Pavel Machek
2008-06-04 23:43       ` Éric Piel
2008-06-05  6:29         ` Jean Delvare
2008-06-05  9:38           ` [lm-sensors] " Jonathan Cameron
2008-06-05 20:34             ` Éric Piel
2008-06-05 22:27               ` Pau Oliva Fora
2008-06-06 14:24                 ` Dmitry Torokhov
2008-06-06 15:29                   ` Pau Oliva Fora
2008-06-06 14:56                 ` Eric Piel
2008-06-06 15:30                   ` Pau Oliva Fora [this message]
2008-06-06  8:51               ` Jonathan Cameron
2008-06-04 23:03   ` Pavel Machek
2008-06-04 23:29     ` Éric Piel
2008-06-05  1:06     ` Henrique de Moraes Holschuh
2008-06-05  8:19       ` Pavel Machek
2008-06-06 14:27   ` Dmitry Torokhov
2008-06-06 14:59     ` Eric Piel
2008-06-06 15:11       ` Dmitry Torokhov
2008-06-06 15:37       ` Pau Oliva Fora
2008-06-05  5:17 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Andrew Morton
2008-06-05  7:43 ` [lm-sensors] " Riku Voipio
2008-06-05  8:28   ` Eric Piel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48495831.3050404@eslack.org \
    --to=pau@eslack.org \
    --cc=Dmitry@ATrpms.net \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=Eric.Piel@tremplin-utc.net \
    --cc=Yan@ATrpms.net \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=burman.yan@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jic23@cam.ac.uk \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox