From: Pau Oliva Fora <pau@eslack.org>
To: Eric Piel <eric.piel@tremplin-utc.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@osdl.org>,
pavel@ucw.cz, Arjan van de Ven <arjan@infradead.org>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Yan Burman <burman.yan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
HWMON <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!
Date: Fri, 06 Jun 2008 17:37:33 +0200 [thread overview]
Message-ID: <484959BD.6050407@eslack.org> (raw)
In-Reply-To: <484950D2.9070809@tremplin-utc.net>
Eric Piel wrote:
>> I would recommend converting the input piece to input_polled_device
>> instead of managing the polling thread by yourselves.
> Yes, you are right, I had forgotten about this one! That said, for now
> I'm working on removing the polling and relying only the interrupts. So
> if it works that shouldn't be needed :-)
>
I think going to interrupt-only approach will cause a problem in the HTC
Shift:
In CTRL_REG2 (21h) if you set to 1 the Interrupt ENable (IEN) field the
device shuts down.
I guess HTC took the "polling" approach in the windows driver, and they
enable the interrupt when the sensor reports a "free fall" event, to
have the disk parked and protect the hardware from being damaged.
Maybe you can keep the input_polled_device together with interrupts and
select one or the other depending on DMI information (same as for
swaping the axis, etc.)
Cheers,
Pau Oliva
next prev parent reply other threads:[~2008-06-06 15:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 12:05 [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Yan Burman
2008-06-04 19:24 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-04 20:58 ` Jean Delvare
2008-06-04 22:57 ` Éric Piel
2008-06-05 6:27 ` Jean Delvare
2008-06-04 23:05 ` Pavel Machek
2008-06-04 23:43 ` Éric Piel
2008-06-05 6:29 ` Jean Delvare
2008-06-05 9:38 ` [lm-sensors] " Jonathan Cameron
2008-06-05 20:34 ` Éric Piel
2008-06-05 22:27 ` Pau Oliva Fora
2008-06-06 14:24 ` Dmitry Torokhov
2008-06-06 15:29 ` Pau Oliva Fora
2008-06-06 14:56 ` Eric Piel
2008-06-06 15:30 ` Pau Oliva Fora
2008-06-06 8:51 ` Jonathan Cameron
2008-06-04 23:03 ` Pavel Machek
2008-06-04 23:29 ` Éric Piel
2008-06-05 1:06 ` Henrique de Moraes Holschuh
2008-06-05 8:19 ` Pavel Machek
2008-06-06 14:27 ` Dmitry Torokhov
2008-06-06 14:59 ` Eric Piel
2008-06-06 15:11 ` Dmitry Torokhov
2008-06-06 15:37 ` Pau Oliva Fora [this message]
2008-06-05 5:17 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Andrew Morton
2008-06-05 7:43 ` [lm-sensors] " Riku Voipio
2008-06-05 8:28 ` Eric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484959BD.6050407@eslack.org \
--to=pau@eslack.org \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=burman.yan@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox