From: "H. Peter Anvin" <hpa@kernel.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "Adrian Bunk" <bunk@kernel.org>,
"\"S.Çağlar Onur\"" <caglar@pardus.org.tr>,
linux-kernel@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Frank Seidel" <fseidel@suse.de>,
"Onur Küçük" <onur@pardus.org.tr>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [2.6.26 patch] fat_valid_media() isn't for userspace
Date: Sun, 08 Jun 2008 18:14:01 -0700 [thread overview]
Message-ID: <484C83D9.2020402@kernel.org> (raw)
In-Reply-To: <87prqrn4d8.fsf@duaron.myhome.or.jp>
OGAWA Hirofumi wrote:
>
> Yes. This is new one, so it shouldn't have any users of that.
> Looks more better. Thanks.
>
The other thing about this header that needs to be fixed is the
definition of the following ioctls:
#define VFAT_IOCTL_READDIR_BOTH _IOR('r', 1, struct dirent [2])
#define VFAT_IOCTL_READDIR_SHORT _IOR('r', 2, struct dirent [2])
"struct dirent" is a kernel type here, but is a **different type** in
userspace! This means both the structure and the IOCTL number is wrong!
We need to make this either __kernel_dirent_t[*] or something like
struct __msdos_fs_dirent.
-hpa
[*] Yes, typedefs suck, but unfortunately C doesn't allow aliases in the
structure tag namespace.
next prev parent reply other threads:[~2008-06-09 1:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 18:16 [PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace S.Çağlar Onur
2008-06-08 18:36 ` OGAWA Hirofumi
2008-06-08 18:43 ` [2.6.26 patch] fat_valid_media() isn't " Adrian Bunk
2008-06-08 18:55 ` OGAWA Hirofumi
2008-06-09 1:14 ` H. Peter Anvin [this message]
2008-06-09 4:12 ` OGAWA Hirofumi
2008-06-09 4:41 ` H. Peter Anvin
2008-06-09 8:05 ` Adrian Bunk
2008-06-09 22:26 ` [2.6 patch] fat/dir.c: switch to struct __fat_fs_dirent Adrian Bunk
2008-06-09 23:12 ` OGAWA Hirofumi
2008-06-09 22:27 ` [2.6 patch] remove the in-kernel struct dirent{,64} Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484C83D9.2020402@kernel.org \
--to=hpa@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=caglar@pardus.org.tr \
--cc=fseidel@suse.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=onur@pardus.org.tr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox