Re: [PATCH 06/10] HID: move logitech report quirks

Jiri Kosina
2008-06-16T10:15:54Z

On Mon, 9 Jun 2008, Jiri Slaby wrote:

> > > Move them from core code to a separate driver.
> > is there a reason why this moves only the report descriptor
> > Logitech-specific quirks, but leaves the input mapping still in
> > hid-input-quirks.c and doesn't move it into ->input_mapping method
> > too?
> No, there is no strong reason, I just postponed it to the second round of
> changes. I wanted to hear comments first, so I only moved fully only apple
> driver (to present how the concept was thought). After things settle down, I'm
> going to move the rest of quirks including this one.

Thanks a lot. Would you please care to do another round of submission,
with the missing assignment fixed in the apple driver, and also with the
->input_mapping added too?

I would like to avoid a situation when we have a part of functionality for
certain devices implemented in generic driver and a part in specialized
driver, if possible.

Thanks a lot,

--
Jiri Kosina
SUSE Labs