From: Andi Kleen <andi@firstfloor.org>
To: Bernhard Walle <bwalle@suse.de>
Cc: Vivek Goyal <vgoyal@redhat.com>,
Johannes Weiner <hannes@saeurebad.de>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
hpa@zytor.com, anderson@redhat.com,
Amul Shah <amul.shah@unisys.com>
Subject: Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()
Date: Mon, 09 Jun 2008 18:39:39 +0200 [thread overview]
Message-ID: <484D5CCB.5020709@firstfloor.org> (raw)
In-Reply-To: <20080609182341.00d6e746@halley.suse.de>
Bernhard Walle wrote:
> * Vivek Goyal [2008-06-09 09:22]:
>> Kdump first kernel always tries to reserve just physical RAM and nothing
>> else. So I am not sure what does above code do. Try to reserve a memory
>> which is not RAM but is in the region less than highest mapped entity and
>> in that case return silently without any warning. In what case do we
>> exercise this path?
>
> I don't know. That code has been introduced in
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=5e58a02a8f6a7a1c9ae41f39286bcd3aea0d6f24
>
> Ccing Andi.
>
> IMO we should not print any warning in that function, leaving the error
> handling to the caller.
Don't remember the details. Perhaps Amul does (cc'ed)
-Andi
next prev parent reply other threads:[~2008-06-09 16:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 13:46 [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Bernhard Walle
2008-06-08 13:46 ` [patch 1/3] Add return value to reserve_bootmem_node() Bernhard Walle
2008-06-08 13:46 ` [patch 2/3] Add flags parameter to reserve_bootmem_generic() Bernhard Walle
2008-06-08 14:26 ` WANG Cong
2008-06-08 17:12 ` Bernhard Walle
2008-06-08 22:01 ` Johannes Weiner
2008-06-09 13:22 ` Vivek Goyal
2008-06-09 16:23 ` Bernhard Walle
2008-06-09 16:39 ` Andi Kleen [this message]
2008-06-09 19:50 ` Amul Shah
2008-06-09 20:17 ` Bernhard Walle
2008-06-09 20:29 ` Vivek Goyal
2008-06-09 20:42 ` Bernhard Walle
2008-06-09 20:54 ` Vivek Goyal
2008-06-09 20:57 ` Bernhard Walle
2008-06-09 21:00 ` Vivek Goyal
2008-06-09 21:04 ` Bernhard Walle
2008-06-09 16:25 ` Bernhard Walle
2008-06-08 22:06 ` Johannes Weiner
2008-06-09 16:37 ` Bernhard Walle
2008-06-08 13:46 ` [patch 3/3] Use reserve_bootmem_generic() to reserve crashkernel memory on x86_64 Bernhard Walle
2008-06-09 13:06 ` [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Vivek Goyal
2008-06-10 12:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D5CCB.5020709@firstfloor.org \
--to=andi@firstfloor.org \
--cc=amul.shah@unisys.com \
--cc=anderson@redhat.com \
--cc=bwalle@suse.de \
--cc=hannes@saeurebad.de \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox