From: Jiri Slaby <jirislaby@gmail.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk
Date: Tue, 10 Jun 2008 23:51:21 +0200 [thread overview]
Message-ID: <484EF759.3030806@gmail.com> (raw)
In-Reply-To: <20080610214255.GA27749@frolo.macqel>
On 06/10/2008 11:42 PM, Philippe De Muyter wrote:
> Hello everybody,
>
> In the cirrusfb driver, the RAM address printk has a superfluous 'x'
> that could be interpreted as "don't care", while it is actually a typo.
> Fix that.
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
>
> diff -r 184e1bb486cf drivers/video/cirrusfb.c
> --- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700
> +++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200
> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct
> info->screen_size = board_size;
> cinfo->unmap = cirrusfb_pci_unmap;
>
> - printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
> + printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
> info->screen_size >> 10, board_addr);
Hmm, is there \n missing too?
> printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
> pci_set_drvdata(pdev, info);
next prev parent reply other threads:[~2008-06-10 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 21:42 [PATCH] driver/video/cirrusfb : Fix RAM address printk Philippe De Muyter
2008-06-10 21:51 ` Jiri Slaby [this message]
2008-06-10 22:14 ` Philippe De Muyter
2008-06-10 22:15 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484EF759.3030806@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox