* [PATCH] driver/video/cirrusfb : Fix RAM address printk
@ 2008-06-10 21:42 Philippe De Muyter
2008-06-10 21:51 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Philippe De Muyter @ 2008-06-10 21:42 UTC (permalink / raw)
To: linux-kernel
Hello everybody,
In the cirrusfb driver, the RAM address printk has a superfluous 'x'
that could be interpreted as "don't care", while it is actually a typo.
Fix that.
Signed-off-by: Philippe De Muyter <phdm@macqel.be>
diff -r 184e1bb486cf drivers/video/cirrusfb.c
--- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700
+++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200
@@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct
info->screen_size = board_size;
cinfo->unmap = cirrusfb_pci_unmap;
- printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
+ printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
info->screen_size >> 10, board_addr);
printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
pci_set_drvdata(pdev, info);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk
2008-06-10 21:42 [PATCH] driver/video/cirrusfb : Fix RAM address printk Philippe De Muyter
@ 2008-06-10 21:51 ` Jiri Slaby
2008-06-10 22:14 ` Philippe De Muyter
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2008-06-10 21:51 UTC (permalink / raw)
To: Philippe De Muyter; +Cc: linux-kernel
On 06/10/2008 11:42 PM, Philippe De Muyter wrote:
> Hello everybody,
>
> In the cirrusfb driver, the RAM address printk has a superfluous 'x'
> that could be interpreted as "don't care", while it is actually a typo.
> Fix that.
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
>
> diff -r 184e1bb486cf drivers/video/cirrusfb.c
> --- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700
> +++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200
> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct
> info->screen_size = board_size;
> cinfo->unmap = cirrusfb_pci_unmap;
>
> - printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
> + printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
> info->screen_size >> 10, board_addr);
Hmm, is there \n missing too?
> printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
> pci_set_drvdata(pdev, info);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk
2008-06-10 21:51 ` Jiri Slaby
@ 2008-06-10 22:14 ` Philippe De Muyter
2008-06-10 22:15 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Philippe De Muyter @ 2008-06-10 22:14 UTC (permalink / raw)
To: Jiri Slaby; +Cc: linux-kernel
On Tue, Jun 10, 2008 at 11:51:21PM +0200, Jiri Slaby wrote:
> On 06/10/2008 11:42 PM, Philippe De Muyter wrote:
>> Hello everybody,
>> In the cirrusfb driver, the RAM address printk has a superfluous 'x'
>> that could be interpreted as "don't care", while it is actually a typo.
>> Fix that.
>> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
>> diff -r 184e1bb486cf drivers/video/cirrusfb.c
>> --- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700
>> +++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200
>> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct
>> info->screen_size = board_size;
>> cinfo->unmap = cirrusfb_pci_unmap;
>> - printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
>> + printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
>> info->screen_size >> 10, board_addr);
>
> Hmm, is there \n missing too?
>
No that would make the RAM adress orphan, but we must also remove KERN_INFO
in the printk below.
>> printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
>> pci_set_drvdata(pdev, info);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk
2008-06-10 22:14 ` Philippe De Muyter
@ 2008-06-10 22:15 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2008-06-10 22:15 UTC (permalink / raw)
To: Philippe De Muyter; +Cc: linux-kernel
On 06/11/2008 12:14 AM, Philippe De Muyter wrote:
> On Tue, Jun 10, 2008 at 11:51:21PM +0200, Jiri Slaby wrote:
>> On 06/10/2008 11:42 PM, Philippe De Muyter wrote:
>>> Hello everybody,
>>> In the cirrusfb driver, the RAM address printk has a superfluous 'x'
>>> that could be interpreted as "don't care", while it is actually a typo.
>>> Fix that.
>>> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
>>> diff -r 184e1bb486cf drivers/video/cirrusfb.c
>>> --- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700
>>> +++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200
>>> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct
>>> info->screen_size = board_size;
>>> cinfo->unmap = cirrusfb_pci_unmap;
>>> - printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
>>> + printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
>>> info->screen_size >> 10, board_addr);
>> Hmm, is there \n missing too?
>>
>
> No that would make the RAM adress orphan, but we must also remove KERN_INFO
> in the printk below.
No please. This makes logs non-atomic. Make one printk from the two.
>>> printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
>>> pci_set_drvdata(pdev, info);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-10 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-10 21:42 [PATCH] driver/video/cirrusfb : Fix RAM address printk Philippe De Muyter
2008-06-10 21:51 ` Jiri Slaby
2008-06-10 22:14 ` Philippe De Muyter
2008-06-10 22:15 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox