From: Pavel Emelyanov <xemul@openvz.org>
To: Ian Kent <raven@themaw.net>
Cc: autofs mailing list <autofs@linux.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>
Subject: [PATCH] autofs4: fix 32-bit userspace vs 64-bit kernel communications
Date: Wed, 11 Jun 2008 13:54:00 +0400 [thread overview]
Message-ID: <484FA0B8.2000002@openvz.org> (raw)
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
The struct autofs_v5_packet has only one difference between
32-bit and 64-bit versions - on 64-bit gcc aligns its size and
it is 4 bytes larger that it is on 32-bit kernel. This confuses
32-bit user-space daemon, when talking to 64-bit kernel.
This is very critical for containerized setups, when containers
with <different>-bit tolls are used.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 1e4a539..9855b6e 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -132,6 +132,14 @@ static void autofs4_notify_daemon(struct autofs_sb_info *sbi,
struct autofs_v5_packet *packet = &pkt.v5_pkt.v5_packet;
pktsz = sizeof(*packet);
+#if defined(CONFIG_X86_64) && defined(CONFIG_IA32_EMULATION)
+ /*
+ * On x86_64 autofs_v5_packet struct is padded with 4 bytes
+ * which breaks 32-bit autofs daemon.
+ */
+ if (test_thread_flag(TIF_IA32))
+ pktsz -= 4;
+#endif
packet->wait_queue_token = wq->wait_queue_token;
packet->len = wq->len;
next reply other threads:[~2008-06-11 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 9:54 Pavel Emelyanov [this message]
2008-06-11 12:32 ` [PATCH] autofs4: fix 32-bit userspace vs 64-bit kernel communications Ian Kent
2008-06-11 12:47 ` Pavel Emelyanov
2008-06-11 13:08 ` Ian Kent
2008-06-11 13:15 ` Ian Kent
2008-06-11 13:25 ` Pavel Emelyanov
2008-06-11 13:40 ` Ian Kent
2008-06-11 14:29 ` Mikael Pettersson
2008-06-12 2:52 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484FA0B8.2000002@openvz.org \
--to=xemul@openvz.org \
--cc=autofs@linux.kernel.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox