From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2994315AbcBSWZX (ORCPT ); Fri, 19 Feb 2016 17:25:23 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54981 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993165AbcBSWZV (ORCPT ); Fri, 19 Feb 2016 17:25:21 -0500 From: Arnd Bergmann To: Murali Karicheri Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc Date: Fri, 19 Feb 2016 23:25:11 +0100 Message-ID: <4850949.nFTN7kbEd4@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56C79585.1090905@ti.com> References: <1455904724-17952-1-git-send-email-m-karicheri2@ti.com> <3256728.DYdlef6xAF@wuerfel> <56C79585.1090905@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:D9tHlLl8D8++nLpTDoe4VXYadAmb7zqOZa+jT6jA0hmAt1SFLfq 84g/j3ZYA9+I3bNhqQKV9R0LYdJUkhGaZnIqSISUVjg4Rsces4i9C0dIDU5RkEVgLkI24w5 +A0vxvE5/YsPw8ZrnpFkG0AAVtvbCZyyxknmB5IM7dqZ0wdPz+vmXdAsF8yNFYTWBzuQORu gbVOCl1nrreUBcSHRKwUg== X-UI-Out-Filterresults: notjunk:1;V01:K0:pMLU0wdK7Cs=:o+rAiplIWZB3Rjz54B5iYt EVb/purLAu924BNAx9eEBG1zquCcpjzN1se1MCp33lXfRcMOxcNXf9mQ+xKxa9KACIjypkBMP OOrINReqm0ZOXOyV/2kq/kfmMyRcnfBisFsC3jle9uqy6Tpa9Ro4uF5Is/L7KLFlUiVHSTXwb P6nn9NU4tsLcILx+a3zm5tK6ufzDgQPts+OeqnOhZHlkP6TbItxTahCBDo1Od2gvtOrbo1zl4 dV4mPfHl3rTqkly992rpU1wwC22IOfZ6u9epGAQiKvpGeAzqGzZJc7SaXkEzPPASc4E/wG7GC pgQHa0j7A9katm8d+WndFEHRlG0KlS4RgWaV5MpkGWF/E5GDmu+AzntPEaRg/8R5wEpyY+ApB jgBWkPgl/O6XKpJjmudf76fc86J9F3l+FVuN84PFhLDs6akZQj+Ze3Jac0JIzRj3egzaFgNI5 llMD0YYBnjj2xNyf5kHFezkE1YMPJo7BTOexP/W3fIeiG4dGglX9ClDqrpZmMpKmSWpRMQxeT 6SI4b6C0HF39A/73AeSklvu4GBKnYdZIhuYvF2wjPCt72X4U8W2lUW8H9XKzI+t4orDAqJO+G 3Jq0YyZ8JifuDzbzDQyyZcyR2OCrVseMzu59pnruYkvHp8u2YVnngVUnGcF+pV4GNj0R8IEWO xD4Yo/DNukJtULHUBWV0TE+mGn1bTuzReZqMY6n8T1qMZpSwK2L6HBmeg+HL6mmIc8lLAVKSV NHz+wgZ3KEpCPI0b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 19 February 2016 17:21:57 Murali Karicheri wrote: > >> get_pkt_info(&dma_buf, &tmp, &dma_desc, ndesc); > >> - get_sw_data((u32 *)&buf_ptr, &buf_len, ndesc); > >> + /* warning!!!! We are retrieving the virtual ptr in the sw_data > >> + * field as a 32bit value. Will not work on 64bit machines > >> + */ > >> + buf_ptr = (void *)GET_SW_DATA0(ndesc); > >> + buf_len = (int)GET_SW_DATA1(desc); > > > > I would have abstracted the retrieval of a pointer again, > > and added the comment in the helper function once, it doesn't > > really need to be duplicated everywhere. > > > Arnd, > > I thought about it to add it to the API. API currently set buffer > and ptr. It would be an issue only if store/retrieve ptr in/from the sw_data. > So for the comment to be really useful to someone who is changing the code, > doesn't it make sense to add it at the point of invocation as done in this > patch? No? > Up to you, it was just an idea and you have my Ack either way. Arnd