Re: [PATCH] x86: use add_highpages_with_active_regions for high pages init

Yinghai Lu
2008-06-16T05:43:24Z

On Sun, Jun 15, 2008 at 10:38 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> Huang, Ying wrote:
>>
>> On Sun, 2008-06-15 at 20:46 -0700, Yinghai Lu wrote:
>> [...]
>>>
>>> don't need,
>>> EFI memmap should be reserved in e820map, so it should not show up in
>>> early_node_map.
>>
>> I don't think so. EFI memmap comes from boot-loader not from BIOS. It
>> contains boot-loader execution information (such as EfiLoaderCode,
>> EfiLoaderData, etc), and it will be located at different position for
>> each system reboot.
>>
>> If it is reserved in E820 memmap, hibernation can not work. Because the
>> memory area for EFI memmap is not E820 RAM, it is not saved during
>> hibernating and restored after restoring from disk.
>>
>> Linked list of struct setup_data has similar requirement too.
>>
>
> That doesn't mean we can't use the E820 memory map structure for it. We
> just have to define a new kernel-internal memory type, instead of using type
> 2 (reserved).

yes. then just modify e820_mark_nosave_regions a little bit.

YH