From: David Newall <davidn@davidnewall.com>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Trivial Patch Monkey <trivial@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] 8139too: different style cleanups
Date: Sun, 15 Jun 2008 15:56:12 +0930 [thread overview]
Message-ID: <4854B604.6080900@davidnewall.com> (raw)
In-Reply-To: <48541173.7040905@freemail.hu>
Németh Márton wrote:
> # define DPRINTK(fmt, args...) \
> - printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
> + printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
>
Why change __FUNCTION__ to __func__? I don't even know where __func__
come from? Assuming that it isn't totally broken, and I'll believe that
it isn't, then would it be compiler-specific? __FUNCTION__ is standard
and that's more than enough reason to prefer that form to any
non-standard variation.
Yes to the following; no to all the rest:
> -#define RTL8139_CAPS HAS_CHIP_XCVR|HAS_LNK_CHNG
> +#define RTL8139_CAPS (HAS_CHIP_XCVR|HAS_LNK_CHNG)
next prev parent reply other threads:[~2008-06-15 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 12:37 [PATCH 2/2] 8139too: different style cleanups Németh Márton
2008-06-14 18:44 ` Németh Márton
2008-06-15 6:26 ` David Newall [this message]
2008-06-15 6:50 ` Harvey Harrison
2008-06-16 5:09 ` [PATCH] 8139too: add missing brackets Németh Márton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4854B604.6080900@davidnewall.com \
--to=davidn@davidnewall.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox