public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Andreas Herrmann <aherrman@arcor.de>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
	gigaset307x-common@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	kkeil@suse.de
Subject: Re: [PATCH] gigaset: fix module reference counting
Date: Mon, 16 Jun 2008 01:09:57 +0200	[thread overview]
Message-ID: <4855A145.90803@imap.cc> (raw)
In-Reply-To: <20080606223918.GA10348@kodscha>

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi Andreas,

On 2008-06-07 00:39, Andreas Herrmann wrote:
> bas_gigaset can't be unloaded due to wrong module reference counting.
> Ensure that module_put is called whenever a channel is freed.

I'm not quite happy with that patch. Specifically, I see a risk of
module_put being called too often.

Could you explain in some more detail what bug you are trying to fix?
Do you have a sequence of events which leads to a situation where the
bas_gigaset module cannot be unloaded but should be?


Thanks,
Tilman


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

  reply	other threads:[~2008-06-15 23:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 22:39 [PATCH] gigaset: fix module reference counting Andreas Herrmann
2008-06-15 23:09 ` Tilman Schmidt [this message]
2008-06-23  7:32   ` Andreas Herrmann
2008-06-23  7:38     ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4855A145.90803@imap.cc \
    --to=tilman@imap.cc \
    --cc=aherrman@arcor.de \
    --cc=akpm@linux-foundation.org \
    --cc=gigaset307x-common@lists.sourceforge.net \
    --cc=hjlipp@web.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox