Re: [PATCH] introduce task cgroup v2

KOSAKI Motohiro
2008-06-16T07:08:18Z

> I guess you didn't notice this comment ? :)

Agghhh, you are right.
sorry.

> >> --- a/kernel/fork.c
> >> > +++ b/kernel/fork.c
> >> > @@ -54,6 +54,7 @@
> >> > #include <linux/tty.h>
> >> > #include <linux/proc_fs.h>
> >> > #include <linux/blkdev.h>
> >> > +#include <linux/cgroup_task.h>
> >> >
> >> > #include <asm/pgtable.h>
> >> > #include <asm/pgalloc.h>
> >> > @@ -920,6 +921,8 @@ static struct task_struct *copy_process(
> >> > p->user != current->nsproxy->user_ns->root_user)
> >> > goto bad_fork_free;
> >> > }
> >> > + if (task_cgroup_can_fork(p))
> >> > + goto bad_fork_free;
> >
> > If task_cgroup_can_fork() returns 0, but copy_process() fails afterwords,
> > taskcg->nr_tasks will be in a wrong state.

Sure.
I'll fix it, of cource.

Thanks!