From: Jeremy Fitzhardinge <jeremy@goop.org>
To: the arch/x86 maintainers <x86@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Isaku Yamahata <yamahata@valinux.co.jp>,
Samuel Thibault <samuel.thibault@eu.citrix.com>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: [PATCH] xen: Use wmb instead of rmb in xen_evtchn_do_upcall().
Date: Mon, 16 Jun 2008 14:58:13 -0700 [thread overview]
Message-ID: <4856E1F5.2000002@goop.org> (raw)
From: Isaku Yamahata <yamahata@valinux.co.jp>
This patch is ported one from 534:77db69c38249 of linux-2.6.18-xen.hg.
Use wmb instead of rmb to enforce ordering between
evtchn_upcall_pending and evtchn_pending_sel stores
in xen_evtchn_do_upcall().
Cc: Samuel Thibault <samuel.thibault@eu.citrix.com>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
drivers/xen/events.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
===================================================================
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -529,7 +529,7 @@ void xen_evtchn_do_upcall(struct pt_regs *regs)
#ifndef CONFIG_X86 /* No need for a barrier -- XCHG is a barrier on x86. */
/* Clear master flag /before/ clearing selector flag. */
- rmb();
+ wmb();
#endif
pending_words = xchg(&vcpu_info->evtchn_pending_sel, 0);
while (pending_words != 0) {
--
1.5.3
next reply other threads:[~2008-06-16 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 21:58 Jeremy Fitzhardinge [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-10 7:35 [PATCH] xen: Use wmb instead of rmb in xen_evtchn_do_upcall() Isaku Yamahata
2008-06-10 7:41 ` Nick Piggin
2008-06-10 7:57 ` Jeremy Fitzhardinge
2008-06-10 8:15 ` Nick Piggin
2008-06-11 6:54 ` Jeremy Fitzhardinge
2008-06-10 8:01 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4856E1F5.2000002@goop.org \
--to=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=samuel.thibault@eu.citrix.com \
--cc=x86@kernel.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox