public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@kernel.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: make asm/asm.h work for asm code.
Date: Mon, 16 Jun 2008 15:44:16 -0700	[thread overview]
Message-ID: <4856ECC0.3050201@kernel.org> (raw)
In-Reply-To: <4856E3D3.2010207@goop.org>

Jeremy Fitzhardinge wrote:

> +# define __ASM_INC    incl
> +# define __ASM_INC    incq
> +#define _ASM_INC    __ASM_INC
> +#define _ASM_INC    " " __stringify(__ASM_INC) " "

You have *exactly* as many #defines as if one would simply do four cases 
(32 C, 64 C, 32 asm, 64 asm), and that would be easier to read...

	-hpa

  reply	other threads:[~2008-06-16 22:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 22:06 [PATCH] x86: make asm/asm.h work for asm code Jeremy Fitzhardinge
2008-06-16 22:44 ` H. Peter Anvin [this message]
2008-06-16 22:48 ` H. Peter Anvin
2008-06-16 23:08   ` Jeremy Fitzhardinge
2008-06-16 23:13     ` H. Peter Anvin
2008-06-17 20:45       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4856ECC0.3050201@kernel.org \
    --to=hpa@kernel.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox