public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Esben Haabendal <eha@doredevelopment.dk>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Add support for IRQ_NOAUTOEN in __set_irq_handler
Date: Thu, 19 Jun 2008 21:37:37 +0200	[thread overview]
Message-ID: <485AB581.9070509@doredevelopment.dk> (raw)

Any reason for __set_irq_handler not supporting the IRQ_NOAUTOEN flag?

/Esben

 kernel/irq/chip.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 964964b..42bb163 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -584,10 +584,15 @@ __set_irq_handler(unsigned int irq,
irq_flow_handler_t handle, int is_chained,
 	desc->name = name;

 	if (handle != handle_bad_irq && is_chained) {
-		desc->status &= ~IRQ_DISABLED;
 		desc->status |= IRQ_NOREQUEST | IRQ_NOPROBE;
-		desc->depth = 0;
-		desc->chip->unmask(irq);
+		if (!(desc->status & IRQ_NOAUTOEN)) {
+			desc->depth = 0;
+			desc->status &= ~IRQ_DISABLED;
+			desc->chip->unmask(irq);
+		} else {
+			/* Undo nested disables: */
+			desc->depth = 1;
+		}
 	}
 	spin_unlock_irqrestore(&desc->lock, flags);
 }

-- 
Esben Haabendal, Senior Software Consultant
DoréDevelopment ApS, Ved Stranden 1, 9560 Hadsund, DK-Denmark
Tlf: +45 51 92 53 93, mail: eha@doredevelopment.dk
WWW: http://www.doredevelopment.dk

             reply	other threads:[~2008-06-19 19:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19 19:37 Esben Haabendal [this message]
2008-06-20  8:19 ` [PATCH] Add support for IRQ_NOAUTOEN in __set_irq_handler Esben Haabendal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485AB581.9070509@doredevelopment.dk \
    --to=eha@doredevelopment.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox