From: Andi Kleen <andi@firstfloor.org>
To: Max Asbock <masbock@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>, venkatesh.pallipadi@intel.com
Subject: Re: mce_64.c: mce_cpu_quirks being ignored
Date: Thu, 19 Jun 2008 23:16:17 +0200 [thread overview]
Message-ID: <485ACCA1.6070507@firstfloor.org> (raw)
In-Reply-To: <1213908276.5942.16.camel@w-amax.beaverton.ibm.com>
Max Asbock wrote:
> static void __cpuinit mce_cpu_quirks(struct cpuinfo_x86 *c)
> {
> /* This should be disabled by the BIOS, but isn't always */
> if (c->x86_vendor == X86_VENDOR_AMD) {
> if(c->x86 == 15)
> /* disable GART TBL walk error reporting, which trips off
> incorrectly with the IOMMU & 3ware & Cerberus. */
> clear_bit(10, &bank[4]);
> ....
>
> Is turning off that bit still needed?
Yes it is. Also referencing the bank is needed for other reasons anyways,
otherwise it would ignore the user sysfs choice on reconfiguration.
Venki, I did a patch for dynamic banks anyways, but haven't submitted it yet.
-Andi
next prev parent reply other threads:[~2008-06-19 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 20:44 mce_64.c: mce_cpu_quirks being ignored Max Asbock
2008-06-19 21:16 ` Andi Kleen [this message]
2008-06-25 0:12 ` Venki Pallipadi
2008-07-03 13:05 ` Ingo Molnar
2008-07-03 13:22 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485ACCA1.6070507@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@us.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox