Re: [PATCH 0/3] e1000,e1000e,igb: make ioport free for adapters that need NO ioport resources

Jeff Kirsher
2008-06-23T23:41:22Z

On Mon, Jun 23, 2008 at 1:28 AM, Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
> Dear Auke
>
>>> * [PATCH 1/3] e1000: make ioport free
>>> * [PATCH 2/3] e1000e: make ioport free
>>> * [PATCH 3/3] igb: make ioport free
>>
>> I think patch 2 and 3 are way too large since igb and e1000e can be
>> totally ioport
>> free at all times. There is no need to keep compatibility code for ioport
>> in those
>> drivers as it's unlikely that this will ever be needed.
>
> I left an old implementation in case adapters that need ioport resources
> appear,
> but it's true that these codes are a little redundant for igb and e1000e
> drivers.
>
>> So, perhaps you can remove the ioport code from those 2 drivers
>> (e1000e/igb)
>> completely and resubmit to Jeff Kirsher?
>
> OK, I'll send them later.
>

The updated patchset looks fine. ACK.

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

--
Cheers,
Jeff