From: Arjan van de Ven <arjan@linux.intel.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq softlockup debugging
Date: Sun, 22 Jun 2008 14:18:25 -0700 [thread overview]
Message-ID: <485EC1A1.1020503@linux.intel.com> (raw)
In-Reply-To: <20080622122845.GA10133@damson.getinternet.no>
Vegard Nossum wrote:
Hi
I like the general idea a lot; some comments below on the patch
>
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index f1fc747..97d47cf 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -296,6 +296,9 @@ extern void softirq_init(void);
> extern void raise_softirq_irqoff(unsigned int nr);
> extern void raise_softirq(unsigned int nr);
>
> +#ifdef CONFIG_SOFTLOCKUP_SOFTIRQ_DEBUG
> +extern void *get_last_softirq_action(int cpu);
> +#endif
you don't need to ifdef prototypes....
(there's only one exception: if the prototype uses types that are ifdef'd themselves, but that's not here)
In general... I don't like that this is a config option. I mean... is there a really strong
reason why this shouldn't just always be there?
next prev parent reply other threads:[~2008-06-22 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 12:28 [PATCH] softirq softlockup debugging Vegard Nossum
2008-06-22 21:18 ` Arjan van de Ven [this message]
2008-06-23 19:31 ` Vegard Nossum
2008-06-24 10:41 ` Johannes Weiner
2008-06-24 11:45 ` Vegard Nossum
2008-06-24 13:06 ` Johannes Weiner
2008-06-24 12:06 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485EC1A1.1020503@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox