From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762948AbYFWTlq (ORCPT ); Mon, 23 Jun 2008 15:41:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761589AbYFWTlg (ORCPT ); Mon, 23 Jun 2008 15:41:36 -0400 Received: from gw.goop.org ([64.81.55.164]:42711 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761573AbYFWTlf (ORCPT ); Mon, 23 Jun 2008 15:41:35 -0400 Message-ID: <485FFC61.9030301@goop.org> Date: Mon, 23 Jun 2008 15:41:21 -0400 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Mike Travis CC: "Eric W. Biederman" , Christoph Lameter , Linux Kernel Mailing List , "H. Peter Anvin" Subject: Re: [crash, bisected] Re: [PATCH 3/4] x86_64: Fold pda into per cpu area References: <20080604003018.538497000@polaris-admin.engr.sgi.com> <20080605102222.GA21319@elte.hu> <484EF29C.7080100@sgi.com> <485947A8.8060801@goop.org> <4859511E.5050605@sgi.com> <48596315.6020104@goop.org> <48596893.4040908@sgi.com> <485AADAC.3070301@sgi.com> <485AB78B.5090904@goop.org> <485AC120.6010202@sgi.com> <485AC5D4.6040302@goop.org> <485ACA8F.10006@sgi.com> <485ACD92.8050109@sgi.com> <485AD138.4010404@goop.org> <485ADA12.5010505@sgi.com> <485ADC73.60009@goop.org> <485BDB04.4090709@sgi.com> <485BE80E.10209@goop.org> <485BF8F5.6010802@goop.org> <485BFFC5.6020404@sgi.com> <485FD56B.1090303@sgi.com> <485FDE80.1010700@goop.org> <485FE5C9.3050305@sgi.com> <485FED2C.8030102@sgi.com> In-Reply-To: <485FED2C.8030102@sgi.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Travis wrote: > The syntax error is at this "DATA(0)" statement. I don't find this as a > linker script command or a macro. What is it we're trying to do with this? > In Eric's sample, it's intended to prevent there being an empty section, which can cause linker bugs. In your case it probably isn't necessary, since you're also putting the percpu data in that section. "DATA" is probably a typo. It should be "LONG" or something like that. (See "3.6.5 Output Section Data" in the linker manual.) J