From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix pte allocation in "x86: introduce init_memory_mapping for 32bit"
Date: Tue, 24 Jun 2008 23:49:14 -0400 [thread overview]
Message-ID: <4861C03A.90107@goop.org> (raw)
In-Reply-To: <86802c440806241441v5f2c0870g379695cacd5dfb9b@mail.gmail.com>
Yinghai Lu wrote:
> thanks.
>
> my test system never use the area from table_start to table_end. and I
> wonder why init_pgtable is that big..
This code looks just like the 64-bit code (I guess it's becoming prime
for unification), and I'd just spent some time debugging a bug in Xen64
caused by an overrun of the allocated area when creating non-PSE
mappings of physical memory. I didn't observe a specific problem with
this code, but consistency and pattern matching made it seem like a
necessary addition. It only ends up reserving the amount of space
actually used, so there's no wasted memory.
If you use PSE to create the mapping and have enough mapped pages anyway
(small kernel), then you may not end up using any of this space.
J
next prev parent reply other threads:[~2008-06-25 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 21:32 [PATCH] x86: fix pte allocation in "x86: introduce init_memory_mapping for 32bit" Jeremy Fitzhardinge
2008-06-24 21:41 ` Yinghai Lu
2008-06-25 3:49 ` Jeremy Fitzhardinge [this message]
2008-06-26 13:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4861C03A.90107@goop.org \
--to=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox