From: Rene Herman <rene.herman@keyaccess.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PNP: have quirk_system_pci_resources() include io resources.
Date: Wed, 25 Jun 2008 23:46:11 +0200 [thread overview]
Message-ID: <4862BCA3.8020005@keyaccess.nl> (raw)
In-Reply-To: <20080625141621.28639b58.akpm@linux-foundation.org>
On 25-06-08 23:16, Andrew Morton wrote:
> On Wed, 25 Jun 2008 19:58:20 +0200
> Rene Herman <rene.herman@keyaccess.nl> wrote:
>
>> + unsigned int type;
>> +
>> + type = pci_resource_flags(pdev, i) &
>> + (IORESOURCE_IO | IORESOURCE_MEM);
>
> pci_resource_flags() returns an unsigned long.
>
> But I think you're right and resource.flags is wrong. Because there's
> no way in which we'll ever be able to use bits 32-63 of that field
> anyway.
>
> I suppose that Someone(tm) should convert resource.flags to a u32 or
> something. Minor issue.
Yes, did notice but pnp_get_resource() then takes those same flags as an
unsigned int -- had to pick one or the other and "the smallest one" then
seemed best...
Rene.
next prev parent reply other threads:[~2008-06-25 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 17:58 [PATCH] PNP: have quirk_system_pci_resources() include io resources Rene Herman
2008-06-25 21:16 ` Andrew Morton
2008-06-25 21:46 ` Rene Herman [this message]
2008-06-25 22:16 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4862BCA3.8020005@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox