From: Rene Herman <rene.herman@keyaccess.nl>
To: Len Brown <lenb@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Robert Hancock <hancockr@shaw.ca>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Hans de Goede <j.w.r.degoede@hhs.nl>,
Jean Delvare <khali@linux-fr.org>,
linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace
Date: Thu, 26 Jun 2008 01:38:44 +0200 [thread overview]
Message-ID: <4862D704.80607@keyaccess.nl> (raw)
In-Reply-To: <alpine.LFD.1.10.0806251913090.3279@localhost.localdomain>
On 26-06-08 01:16, Len Brown wrote:
>
>> +config THERMAL_HWMON
>> + bool "Hardware monitoring support"
>> + depends on HWMON=y || HWMON=THERMAL
>
>
> for
> CONFIG_HWMON=m
> CONFIG_THERMAL=y
> CONFIG_THERMAL_HWMON=n, always.
>
> This is not a change to the logic of the existing ifdefs,
> but was wondering if this was your intent, Rui.
My intentioon in this case. Yes, this should be. THERMAL_HWMON is a bool
(as in, not a tristate) that just changes THERMAL.
If THERMAL=y, we need HWMON=y or we'd get a link failure. If THERMAL=m,
we're okay with either HWMON=y and HWMON=m and if THERMAL=n, we don't
care one hoot about THERMAL_HWMON...
Rene.
next prev parent reply other threads:[~2008-06-25 23:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.4PGqX9CuLbgiTimfCcon+PlAMxk@ifi.uio.no>
[not found] ` <fa.PWu620xEt5OlYdOezvRtQriuNjM@ifi.uio.no>
2008-06-24 2:17 ` [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace Robert Hancock
2008-06-24 3:07 ` Linus Torvalds
2008-06-24 3:47 ` Zhang Rui
2008-06-24 12:14 ` Mark M. Hoffman
2008-06-24 17:38 ` Rene Herman
2008-06-25 23:12 ` Len Brown
2008-06-26 0:17 ` Matthew Garrett
2008-06-25 23:16 ` Len Brown
2008-06-25 23:38 ` Rene Herman [this message]
2008-06-26 0:57 ` Zhang Rui
2008-06-24 6:59 ` Jean Delvare
2008-06-24 9:28 ` Rene Herman
2008-06-24 11:45 ` Mark M. Hoffman
2008-06-23 15:06 Rene Herman
2008-06-23 17:06 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4862D704.80607@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=hancockr@shaw.ca \
--cc=j.w.r.degoede@hhs.nl \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=rui.zhang@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox