From: "H. Peter Anvin" <hpa@kernel.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Bernhard Walle <bwalle@suse.de>, Vivek Goyal <vgoyal@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, yhlu.kernel@gmail.com
Subject: Re: [PATCH 1/2] Add /sys/firmware/memmap
Date: Thu, 26 Jun 2008 11:00:16 -0700 [thread overview]
Message-ID: <4863D930.2040300@kernel.org> (raw)
In-Reply-To: <18531.23894.572847.322265@harpo.it.uu.se>
Mikael Pettersson wrote:
> Bernhard Walle writes:
> > > It should be configurable. Whether it's done via CONFIG_KEXEC or its own
> > > option I don't care.
> >
> > Ok, changed:
> >
> > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> > index 1008737..73fcc59 100644
> > --- a/drivers/firmware/Kconfig
> > +++ b/drivers/firmware/Kconfig
> > @@ -28,7 +28,7 @@ config EDD_OFF
> >
> > config FIRMWARE_MEMMAP
> > def_bool y
> > - depends on X86_64 || X86_32
> > + depends on (X86_64 || X86_32) && KEXEC
> >
> > config EFI_VARS
> > tristate "EFI Variable Support via sysfs"
>
> Yep, thanks.
>
Making this depend on KEXEC would be most unfortunate. This is valuable
information for finding all kinds of issues even in the absence of KEXEC.
I really don't see a point in making this configurable, except perhaps
under CONFIG_EMBEDDED.
-hpa
next prev parent reply other threads:[~2008-06-26 18:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 19:57 x86: Add /sys/firmware/memmap Bernhard Walle
2008-06-25 19:57 ` [PATCH 1/2] " Bernhard Walle
2008-06-25 22:43 ` Vivek Goyal
2008-06-26 8:13 ` Mikael Pettersson
2008-06-26 8:45 ` Bernhard Walle
2008-06-26 9:11 ` Mikael Pettersson
2008-06-26 18:00 ` H. Peter Anvin [this message]
2008-06-26 18:18 ` Vivek Goyal
2008-06-26 19:18 ` H. Peter Anvin
2008-06-26 18:23 ` Bernhard Walle
2008-06-26 12:42 ` Vivek Goyal
2008-06-26 8:15 ` Bernhard Walle
2008-06-25 19:57 ` [PATCH 2/2] Use FIRMWARE_MEMMAP on x86/E820 Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2008-06-26 8:14 x86: Add /sys/firmware/memmap Bernhard Walle
2008-06-26 8:14 ` [PATCH 1/2] " Bernhard Walle
2008-06-26 20:19 x86: " Bernhard Walle
2008-06-26 20:19 ` [PATCH 1/2] " Bernhard Walle
2008-06-26 20:45 ` Vivek Goyal
2008-06-26 22:24 ` Greg KH
2008-06-27 11:08 ` Bernhard Walle
2008-06-27 11:12 x86: " Bernhard Walle
2008-06-27 11:12 ` [PATCH 1/2] " Bernhard Walle
2008-06-27 18:51 ` Dave Hansen
2008-06-27 20:56 ` Greg KH
2008-07-01 20:30 ` Bernhard Walle
2008-07-01 20:33 ` Ingo Molnar
2008-07-12 0:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4863D930.2040300@kernel.org \
--to=hpa@kernel.org \
--cc=bwalle@suse.de \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox