Re: [PATCH 4/5] jbd: fix error handling for checkpoint io

Hidehiro Kawai
2008-06-03T04:32:14Z

Hello,

Thank you for reviewing.

Jan Kara wrote:

>>@@ -347,6 +361,8 @@ restart:
>> break;
>> }
>> retry = __process_buffer(journal, jh, bhs,&batch_count);
>>+ if (retry < 0)
>>+ result = retry;
>
> Here you update result whenever retry is < 0 and below when result == 0.
> I think it's better to have these two consistent (not that it would be
> currently any functional difference).

I fixed it.

> Only please add a comment in front of
> log_do_checkpoint() that it's supposed to be called with j_checkpoint_mutex
> held so that EIO propagation works correctly.

I added a comment.

I'll send the revised patch soon.

Thanks,
--
Hidehiro Kawai
Hitachi, Systems Development Laboratory
Linux Technology Center