Re: [PATCH 2/5] jbd: ordered data integrity fix

Andrew Morton
2008-06-03T22:34:49Z

On Mon, 02 Jun 2008 19:45:04 +0900
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> wrote:

> In ordered mode, if a buffer being dirtied exists in the committing

I changed this text to read "if a file data buffer being dirtied".
Please do be careful when describing all these buffers, else it gets
more confusing that it already is.

> transaction, we write the buffer to the disk, move it from the
> committing transaction to the running transaction, then dirty it.
> But we don't have to remove the buffer from the committing
> transaction when the buffer couldn't be written out, otherwise it
> would miss the error and the committing transaction would not abort.
>
> This patch adds an error check before removing the buffer from the
> committing transaction.