From: "Chris Friesen" <cfriesen@nortel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip/master] x86: nmi_watchdog - documentation fix
Date: Fri, 27 Jun 2008 10:32:12 -0600 [thread overview]
Message-ID: <4865160C.2040403@nortel.com> (raw)
In-Reply-To: <20080627165937.2f1fb661@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Fri, 27 Jun 2008 16:54:19 +0100 (BST)
> "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
>
>
>>On Fri, 27 Jun 2008, Cyrill Gorcunov wrote:
>>
>>
>>>+NOTE: Prior to 2.4.2-ac18 the NMI-oopser is enabled unconditionally
>>>+on x86 SMP boxes.
>>
>> While you are at it: s/is/was/.
>
>
> Erm - why ??
>
> It is still true today that kernels < 2.4.2-ac8 have the NMI oopser
> enabled.
To my ear the phrase as written implies past tense for the author/reader
(i.e. "at points in time prior to the release of 2.4.2-ac18"), and thus
grates against "is".
The following sounds better to me: "In kernels prior to 2.4.2-ac18 the
NMI-oopser is enabled..." In this context the phrase itself is in the
present, but we point to past kernels.
Chris
next prev parent reply other threads:[~2008-06-27 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 15:43 [PATCH -tip/master] x86: nmi_watchdog - documentation fix Cyrill Gorcunov
2008-06-27 15:54 ` Maciej W. Rozycki
2008-06-27 15:59 ` Alan Cox
2008-06-27 16:32 ` Chris Friesen [this message]
2008-06-27 16:51 ` Cyrill Gorcunov
2008-06-27 16:56 ` Randy Dunlap
2008-06-27 17:18 ` Cyrill Gorcunov
2008-06-27 17:36 ` Randy Dunlap
2008-06-27 19:32 ` Alan Cox
2008-06-27 20:00 ` Cyrill Gorcunov
2008-06-30 6:50 ` Ingo Molnar
2008-06-27 16:01 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4865160C.2040403@nortel.com \
--to=cfriesen@nortel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox