From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdB0Pwu (ORCPT ); Mon, 27 Feb 2017 10:52:50 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:33973 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdB0Pws (ORCPT ); Mon, 27 Feb 2017 10:52:48 -0500 X-AuditID: b6c32a59-f79736d000001328-69-58b44b486cdb From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Lee Jones , Chanwoo Choi , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [RFT 0/4] mfd: regulator: max14577: Remove support for platform data Date: Mon, 27 Feb 2017 16:52:36 +0100 Message-id: <4868995.DGOuKygKvi@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42LZdlhTXdfDe0uEwdxzrBZTHz5hs7j+5Tmr xfnzG9gt7n89ymjx7UoHk8XlXXPYHNg8ds66y+6xaVUnm8eda3vYPPq2rGL0+LxJLoA1issm JTUnsyy1SN8ugSvj/psOpoKNvBXX119na2A8wtXFyMkhIWAicejidDYIW0ziwr31QDYXh5DA UkaJ+zPaoJx2Jok3d/vZYDp+t05ghUgsB6ratpQJwvnKKPH0+SMWkCo2ASuJie2rGEFsEQFN iet/v4N1MAtsYpT4/Po8WJGwQLBEw9puMJtFQFWi9WE3M4jNC9TwduUksLiogJfEln3tTCA2 J1D9wUePGSFqBCV+TL4HVsMsIC+xb/9UVghbR+LssXWMIMskBOaxS5zc9w0owQHkyEpsOsAM 8YKLxLkZbxkhbGGJV8e3sEPY0hJ/l96Cik9nlNj+WwJizmZGiVW7J0AVWUscPn4RahmfRO/v J0wQ83klOtqEIEo8JM6vfsIKYTtKrD+0AMwWEjjCKHFwsdYERvlZSF6YheSFWUheWMDIvIpR LLWgODc9tdi0wFSvODG3uDQvXS85P3cTIziZaEXuYLwyM+gQowAHoxIP7wqvLRFCrIllxZW5 hxglOJiVRHi/agOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ80YZTIwQEkhPLEnNTk0tSC2CyTJx cEo1MBY0tIYvcKj3b54teNKsZgvP7PiYlTWeL+Y/rBB6ZtIrLP5c8MRpb+8TT2yMNlaKxd9X 3cUVqDijMG//ZIZGNzt95eAAKxPRjohz4iVJ9jddQ2ecTDsnUuCWH2QmoWO8dH34pu3suWeY +JSfdbiJ14ZfP1xTnLCXjSmAR6bQUNQ+Q+bvHzklluKMREMt5qLiRABJq7oNIgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jAV137y0RBp/mi1hMffiEzeL6l+es FufPb2C3uP/1KKPFtysdTBaXd81hc2Dz2DnrLrvHplWdbB53ru1h8+jbsorR4/MmuQDWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb Jbhl3H/TwVSwkbfi+vrrbA2MR7i6GDk5JARMJH63TmCFsMUkLtxbz9bFyMUhJLCUUeJHwwRG COcro8TnvUuZQKrYBKwkJravYgSxRQQ0Ja7//c4KUsQssIlR4tXancwgCWGBYImGtd0sIDaL gKpE68NusDgvUMPblZPA4qICXhJb9rWDDeUEqr+ydA2YLSRwjFHi130ziHpBiR+T74HVMwvI S+zbP5UVwtaSWL/zONMERoFZSMpmISmbhaRsASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS9 5PzcTYzg6HomvYPx8C73Q4wCHIxKPLwWxlsihFgTy4orcw8xSnAwK4nwftUGCvGmJFZWpRbl xxeV5qQWH2I0BXpwIrOUaHI+MPLzSuINTcxNzI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1OTS1I LYLpY+LglGpgFAjf+/MBU2XG3L/2O/pLjY3NZ35Rfa8pIvnyrDrPjOwYd7tfp+WM410uZuZf e3b5SPO53pScu0UHGo5v35GnXLnA1vrY4ndmNQGGhem1epNPL9Pr6y+6Mu1d6U9eteo450er NzMaiTzQTvj8Q4KpKVtX57nao5WxC8/O2tw8+0wKQ/k8bom3SizFGYmGWsxFxYkA5fPsjMQC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170227155239epcas5p2d2932a546c39bcdc4401bf623f93cc30 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 X-RootMTR: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 References: <4488092.RcVZiftjQz@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, February 27, 2017 05:32:37 PM Krzysztof Kozlowski wrote: > On Mon, Feb 27, 2017 at 2:55 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Friday, February 17, 2017 10:01:56 PM Krzysztof Kozlowski wrote: > >> Hi, > >> > >> Minor cleanup of max14577 family of drivers. The dependency inside: > >> 1. Patch #3 and #4 depends for safeness on #1 so no one would try to > >> run the driver on non-DT platform (such platform does not exist anyway...). > >> 2. Patch #4 depends on patch #3 (compile time dependency). > >> > >> Unfortunately I do not have the boards using these drivers, so testing > >> would be appreciated. > > > > Your patchset looks fine to me but I've noticed that > > maxim,max14577 bindings are not used currently in > > the mainline kernel. > > > > AFAIK MAX14577 support is needed only for Gear1 board > > which doesn't have DTS file in the upstream kernel > > (moreover Exynos4212 SoC support has been removed > > recently). > > > > It seems that MAX14577 support should also go away > > (unless there are some other boards using it that we > > support in the mainline kernel). > > The driver supports two chipsets: max14577 and max77836. As you noted, > the first one is for Gear 1. The second one is present on Gear2 which > is supported by mainline. Simplifying the driver to support only > max77836 would be a task requiring testing. I think review would be in > such case not enough. I think that this shouldn't be a big problem (if no one else volunteers we can do the testing on Gear2 device). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics