Re: [patch 00/19] perfmon2 minimal v3: introduction

stephane eranian
2008-07-31T00:28:39Z

Stephen

On Wed, Jul 30, 2008 at 5:21 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Stephane,
>
> On Wed, 30 Jul 2008 16:59:34 -0700 "stephane eranian" <eranian@googlemail.com> wrote:
>>
>> On Mon, Jul 28, 2008 at 11:20 PM, stephane eranian
>> <eranian@googlemail.com> wrote:
>> >> quite a few of the macros (especially for the dummy (non
>> >> CONFIG_PERFMON) versions of functions) should be "static inline"
>> >> functions unless they absolutely must be macros. Andrew Morton said it
>> >> best - "write in C not C preprocessor".
>> >>
>> Do you also have a problem with the debug printk statements using macros?
>
> Not really, they would be a pain to write as C code.
>
That's what I am thinking as well!

> The advantage of using C code for the dummy versions of things is that we
> still get type checking and we eliminate "unused variable" warnings for
> parameters of the functions.
>
Will do the dummy functions as inline then.