Re: [BUILD-FAILURE] linux-next: Tree for June 30

Ingo Molnar
2008-06-30T20:08:20Z

* Sam Ravnborg <sam@ravnborg.org> wrote:

> On Mon, Jun 30, 2008 at 09:26:10PM +0200, Ingo Molnar wrote:
> >
> > * Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > > On Mon, Jun 30, 2008 at 10:13:40PM +0530, Kamalesh Babulal wrote:
> > > > Kamalesh Babulal wrote:
> > > > > Hi Stephen,
> > > > >
> > > > > next-20080630 kernel build fails x86 box
> > > > >
> > > > > fs/bio-integrity.c: In function `bio_integrity_add_page':
> > > > > include/linux/bio.h:368: sorry, unimplemented: inlining failed in call to 'bvec_nr_vecs': function body not available
> > > > > fs/bio-integrity.c:135: sorry, unimplemented: called from here
> > > > > make[1]: *** [fs/bio-integrity.o] Error 1
> > > > > make: *** [fs] Error 2
> > > > >
> > > > > # gcc -v
> > > > > Reading specs from /usr/lib/gcc/i386-redhat-linux/3.4.6/specs
> > > > > Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
> > > > > --infodir=/usr/share/info --enable-shared --enable-threads=posix
> > > > > --disable-checking --with-system-zlib --enable-__cxa_atexit
> > > > > --disable-libunwind-exceptions --enable-java-awt=gtk
> > > > > --host=i386-redhat-linux
> > > > > Thread model: posix
> > > > > gcc version 3.4.6 20060404 (Red Hat 3.4.6-10)
> > > > >
> > > > >
> > > > Another build failure on the same box/config file
> > > >
> > > > make[2]: `scripts/unifdef' is up to date.
> > > > RELOCS arch/x86/boot/compressed/vmlinux.relocs
> > > > 101 section headers supported: 100
> > > > make[2]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
> > > > make[1]: *** [arch/x86/boot/compressed/vmlinux] Error 2
> > > > make: *** [bzImage] Error 2
> > >
> > > In a i386 specific part of the kernel - so let's cc x86 maintainers.
> >
> > that's an allyesconfig kernel and i cannot reproduce the failure with
> > linux-next v2.6.26-rc8-6206-gf1c7436:
> >
> > [...]
> > RELOCS arch/x86/boot/compressed/vmlinux.relocs
> > BUILD arch/x86/boot/compressed/vmlinux.bin.all
> > GZIP arch/x86/boot/compressed/vmlinux.bin.gz
> > LD arch/x86/boot/compressed/piggy.o
> > LD arch/x86/boot/compressed/vmlinux
> > OFFSETS arch/x86/boot/offsets.h
> > OBJCOPY arch/x86/boot/vmlinux.bin
> > AS arch/x86/boot/header.o
> > LD arch/x86/boot/setup.elf
> > OBJCOPY arch/x86/boot/setup.bin
> > BUILD arch/x86/boot/bzImage
> > Root device is (8, 17)
> > Setup is 12524 bytes (padded to 12800 bytes).
> > System is 17840 kB
> > CRC bccb6201
> > Kernel: arch/x86/boot/bzImage is ready (#10848)
> >
> > (nor has anything substantial change in that area changed in the x86
> > tree recently that sticks out at first sight.)
>
> Just to see the number of sections you hit could you try following stupid patch.
> It will casue relocs to terminate but will print out the section header count we have
> in your allyesconfig build.
>
> It is 'funny' that we just passed the limit in the error report.
>
> Sam
>
> diff --git a/arch/x86/boot/compressed/relocs.c b/arch/x86/boot/compressed/relocs.c
> index edaadea..88d27f6 100644
> --- a/arch/x86/boot/compressed/relocs.c
> +++ b/arch/x86/boot/compressed/relocs.c
> @@ -244,7 +244,7 @@ static void read_ehdr(FILE *fp)
> static void read_shdrs(FILE *fp)
> {
> int i;
> - if (ehdr.e_shnum > MAX_SHDRS) {
> + if (1 || ehdr.e_shnum > MAX_SHDRS) {
> die("%d section headers supported: %d\n",
> ehdr.e_shnum, MAX_SHDRS);
> }

ah, ok. So the patch below should solve this for now?

is there any particular reason why we are limited to 100 sections? (is
there some ELF limitation here perhaps?)

Ingo

---------------->
commit db71d27cc7c76e5ff8dd44c7c8c40d1e216658d6
Author: Ingo Molnar <mingo@elte.hu>
Date: Mon Jun 30 22:04:43 2008 +0200

x86: increase MAX_SHDRS from 100 to 200

Kamalesh Babulal reported this build failure:

> make[2]: `scripts/unifdef' is up to date.
> RELOCS arch/x86/boot/compressed/vmlinux.relocs
> 101 section headers supported: 100

Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/boot/compressed/relocs.c b/arch/x86/boot/compressed/relocs.c
index edaadea..668a48b 100644
--- a/arch/x86/boot/compressed/relocs.c
+++ b/arch/x86/boot/compressed/relocs.c
@@ -10,7 +10,7 @@
#define USE_BSD
#include <endian.h>

-#define MAX_SHDRS 100
+#define MAX_SHDRS 200
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
static Elf32_Ehdr ehdr;
static Elf32_Shdr shdr[MAX_SHDRS];