public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: -Wmissing-prototypes (was: make foo() static)
Date: Tue, 01 Jul 2008 08:42:59 +0200	[thread overview]
Message-ID: <4869D1F3.3030804@redhat.com> (raw)
In-Reply-To: <20080630221918.GI1536@cs181140183.pp.htv.fi>

Adrian Bunk wrote:

> This patch makes the needlessly global kvm_smp_prepare_boot_cpu() static.

Hmm, maybe we should build the kernel with -Wmissing-prototypes?
That should make gcc print a warning for that ...

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/

  reply	other threads:[~2008-07-01  6:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 22:19 [2.6 patch] make kvm_smp_prepare_boot_cpu() static Adrian Bunk
2008-07-01  6:42 ` Gerd Hoffmann [this message]
2008-07-01  7:17   ` -Wmissing-prototypes (was: make foo() static) Adrian Bunk
2008-07-05 11:13 ` [2.6 patch] make kvm_smp_prepare_boot_cpu() static Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4869D1F3.3030804@redhat.com \
    --to=kraxel@redhat.com \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox