public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Newall <davidn@davidnewall.com>
To: "Török Edwin" <edwintorok@gmail.com>
Cc: Elias Oltmanns <eo@nebensachen.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Joe Peterson <joe@skyrush.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Ctrl+C doesn't interrupt process waiting for I/O
Date: Tue, 01 Jul 2008 18:42:34 +0930	[thread overview]
Message-ID: <4869F502.5030201@davidnewall.com> (raw)
In-Reply-To: <4869F252.8040600@gmail.com>

Török Edwin wrote:
> David Newall wrote:
>   
>> Elias Oltmanns wrote:
>>   
>>     
>>> -			if (!L_NOFLSH(tty)) {
>>> -				n_tty_flush_buffer(tty);
>>> -				tty_driver_flush_buffer(tty);
>>> -			}
>>>  			if (L_ECHO(tty))
>>>  				echo_char(c, tty);
>>> -			if (tty->pgrp)
>>> -				kill_pgrp(tty->pgrp, signal, 1);
>>> +			isig(signal, tty, 0);
>>>     
>>>       
>> My first reaction is that tty->pgrp must be null.  Perhaps the patch
>> could be simplified...
>>
>>  			if (tty->pgrp)
>>  				kill_pgrp(tty->pgrp, signal, 1);
>> +			else
>> +				isig(signal, tty, 0);
>>
>>
>> Thoughts?
>>   
>>     
>
> isig has the same check, if it is NULL, isig won't deliver the signal
> either
>   

That is odd.  We did see the control-key echoed, so, other than not
flushing output, what's funcitonally different?

  reply	other threads:[~2008-07-01  9:12 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 10:38 Ctrl+C doesn't interrupt process waiting for I/O Török Edwin
2008-06-29  2:44 ` Jeremy Fitzhardinge
2008-06-29  2:45   ` Jeremy Fitzhardinge
2008-06-29  3:42   ` Avi Kivity
2008-06-29  5:13     ` Jeremy Fitzhardinge
2008-06-29  5:39       ` Avi Kivity
2008-06-29  6:25         ` Jeremy Fitzhardinge
2008-06-29  7:45           ` Török Edwin
2008-06-29 23:57           ` Bill Davidsen
2008-06-29 12:37         ` Alan Cox
2008-06-30 17:35       ` J. Bruce Fields
2008-06-29  7:09   ` Török Edwin
2008-06-29  7:23   ` David Newall
2008-06-29 12:10   ` Andi Kleen
2008-06-29 16:02     ` Jeremy Fitzhardinge
2008-06-30 10:30       ` Helge Hafting
2008-07-01  7:47 ` Elias Oltmanns
2008-07-01  8:02   ` Elias Oltmanns
2008-07-01  8:28     ` Török Edwin
2008-07-01  9:59       ` Elias Oltmanns
2008-07-01 12:07       ` Joe Peterson
2008-07-01  8:50   ` David Newall
2008-07-01  9:01     ` Török Edwin
2008-07-01  9:12       ` David Newall [this message]
2008-07-01 14:12   ` Joe Peterson
2008-07-01 14:48     ` Elias Oltmanns
2008-07-01 16:27       ` Joe Peterson
2008-07-02 21:26   ` Joe Peterson
2008-07-04 20:10   ` Joe Peterson
2008-07-04 20:23     ` Alan Cox
2008-07-04 21:17       ` Joe Peterson
2008-07-11 14:47         ` Alan Cox
2008-07-12  0:44           ` Joe Peterson
2008-07-12 10:37             ` Alan Cox
2008-07-04 21:21       ` Andi Kleen
2008-07-04 21:14         ` Alan Cox
2008-07-04 21:36           ` Andi Kleen
2008-07-04 21:44             ` Alan Cox
2008-07-04 22:09               ` Andi Kleen
2008-07-05 10:34                 ` Alan Cox
2008-07-05 11:00                   ` Andi Kleen
2008-07-05 11:34                     ` Alan Cox
2008-07-05 12:49                     ` Elias Oltmanns
2008-07-05 14:01                       ` Andi Kleen
2008-07-05 19:58                       ` Joe Peterson
2008-07-06  8:28                         ` Elias Oltmanns
  -- strict thread matches above, loose matches on Subject: below --
2008-07-03  0:59 Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4869F502.5030201@davidnewall.com \
    --to=davidn@davidnewall.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=edwintorok@gmail.com \
    --cc=eo@nebensachen.de \
    --cc=joe@skyrush.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox