From: Sedji Gaouaou <sedji.gaouaou@atmel.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Andrew Victor <avictor.za@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
VILCHEZ Patrice <Patrice.VILCHEZ@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC
Date: Thu, 03 Jul 2008 16:19:17 +0200 [thread overview]
Message-ID: <486CDFE5.9030105@atmel.com> (raw)
In-Reply-To: <20080703133244.GB17201@flint.arm.linux.org.uk>
Hi Andrew,
>
>> +/*
>> + * MCI (SD/MMC)
>> + */
>> +static struct at91_mmc_data __initdata ek_mmc_data = {
>> + .slot_b = 1,
>> + .wire4 = 1,
>> +// .det_pin = ... not connected
>> +// .wp_pin = ... not connected
>> +// .vcc_pin = ... not connected
>>
>
> Please make these a proper comment, preferably inside the comment before
> the structure. C++ comments are frowned upon in the kernel's source.
>
>
I would like to know what do you suggest about this comment? Indeed we
already use this kind of comments, for instance in board-sam9260ek.c. I
don't mind changing it into the proper comment form, but I would like to
know first what do you suggest.
Regards,
Sedji
next prev parent reply other threads:[~2008-07-03 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 8:39 [PATCH 1/2] Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC Sedji Gaouaou
2008-06-26 8:52 ` Sedji Gaouaou
2008-06-26 19:51 ` Andrew Victor
2008-07-03 13:32 ` Russell King - ARM Linux
2008-07-03 14:19 ` Sedji Gaouaou [this message]
2008-07-03 16:55 ` Russell King - ARM Linux
2008-07-04 8:54 ` Sedji Gaouaou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486CDFE5.9030105@atmel.com \
--to=sedji.gaouaou@atmel.com \
--cc=Patrice.VILCHEZ@atmel.com \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox