From: John Blackwood <john.blackwood@ccur.com>
To: <linux-kernel@vger.kernel.org>
Cc: Andi Kleen <andi-suse@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Todd Allen <todd.allen@ccur.com>
Subject: [PATCH] node meminfo Active & Inactive pages to Kbytes
Date: Thu, 3 Jul 2008 10:35:57 -0400 [thread overview]
Message-ID: <486CE3CD.7090907@ccur.com> (raw)
Hi Andrew and Andi,
We found a minor bug in the output of
/sys/devices/system/node/node[n]/meminfo
where the Active and Inactive values are in pages instead of Kbytes.
Looks like this occurred back in 2.6.20 when the code was changed
over to use node_page_state().
Thanks.
--- linux.2.6.26-rc8/drivers/base/node.c 2008-07-03 09:26:01.000000000 -0400
+++ new/drivers/base/node.c 2008-07-03 09:25:45.000000000 -0400
@@ -84,8 +84,8 @@ static ssize_t node_read_meminfo(struct
nid, K(i.totalram),
nid, K(i.freeram),
nid, K(i.totalram - i.freeram),
- nid, node_page_state(nid, NR_ACTIVE),
- nid, node_page_state(nid, NR_INACTIVE),
+ nid, K(node_page_state(nid, NR_ACTIVE)),
+ nid, K(node_page_state(nid, NR_INACTIVE)),
#ifdef CONFIG_HIGHMEM
nid, K(i.totalhigh),
nid, K(i.freehigh),
next reply other threads:[~2008-07-03 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 14:35 John Blackwood [this message]
2008-07-03 22:42 ` [PATCH] node meminfo Active & Inactive pages to Kbytes Andrew Morton
2008-07-05 15:15 ` John Blackwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486CE3CD.7090907@ccur.com \
--to=john.blackwood@ccur.com \
--cc=akpm@linux-foundation.org \
--cc=andi-suse@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=todd.allen@ccur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox