public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Blackwood <john.blackwood@ccur.com>
To: <linux-kernel@vger.kernel.org>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>,
	Joe Korty <joe.korty@ccur.com>
Subject: [bug ?] do_get_mempolicy()
Date: Thu, 3 Jul 2008 16:44:58 -0400	[thread overview]
Message-ID: <486D3A4A.6000502@ccur.com> (raw)

Hi Lee,

I'm having unexpected results with get_mempolicy(2) in 2.6.26, and
I am hoping that you can either agree with me, or maybe comment on my
misconceptions.

When I have a task with no special task mempolicy (the default mempolicy),
when I call get_mempolicy(2), it returns a policy value of 2 (MPOL_BIND)
with a NULL nodemask.

I believe that this is because of the code in do_get_mempolicy() that does:

  *policy |= pol->flags;

in the else case when flags do not contain MPOL_F_NODE.

I guess I don't understand why we are ORing in the pol->flags into the
*policy value.  For example, when this is for the default_policy, the
MPOL_F_LOCAL flag (which has a value of 2) gets stuffed into the *policy
location, and a get_mempolicy(2) caller sees this as the MPOL_BIND
mempolicy.

Maybe the "*policy |= pol->flags;" line should be removed ?

That is, maybe it was valid at some point, but subsequent changes
make this line of code no longer valid ?

Sorry if I'm out-to-lunch here...

Thanks very much for you time and considerations on this issue.


             reply	other threads:[~2008-07-03 20:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 20:44 John Blackwood [this message]
2008-07-03 21:44 ` [bug ?] do_get_mempolicy() David Rientjes
2008-07-07  7:05   ` David Rientjes
2008-07-08 13:43   ` Lee Schermerhorn
2008-07-08 13:23 ` Lee Schermerhorn
  -- strict thread matches above, loose matches on Subject: below --
2008-07-07 14:41 John Blackwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486D3A4A.6000502@ccur.com \
    --to=john.blackwood@ccur.com \
    --cc=joe.korty@ccur.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox