From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756501AbYGCVDs (ORCPT ); Thu, 3 Jul 2008 17:03:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753725AbYGCVDi (ORCPT ); Thu, 3 Jul 2008 17:03:38 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:56096 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbYGCVDh (ORCPT ); Thu, 3 Jul 2008 17:03:37 -0400 Message-ID: <486D3E88.9090900@garzik.org> Date: Thu, 03 Jul 2008 17:03:04 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: David Woodhouse CC: Theodore Tso , Hugh Dickins , Andrew Morton , KOSAKI Motohiro , mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" References: <20080703020236.adaa51fa.akpm@linux-foundation.org> <20080703205548.D6E5.KOSAKI.MOTOHIRO@jp.fujitsu.com> <486CC440.9030909@garzik.org> <486CCFED.7010308@garzik.org> <1215091999.10393.556.camel@pmac.infradead.org> <486CD654.4020605@garzik.org> <1215093175.10393.567.camel@pmac.infradead.org> <20080703173040.GB30506@mit.edu> <1215111362.10393.651.camel@pmac.infradead.org> In-Reply-To: <1215111362.10393.651.camel@pmac.infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Woodhouse wrote: > Although it does make me wonder if it was better the way I had it > originally, with individual options like TIGON3_FIRMWARE_IN_KERNEL > attached to each driver, rather than a single FIRMWARE_IN_KERNEL option > which controls them all. IMO, individual options would be better. Plus, unless I am misunderstanding, the firmware is getting built into the kernel image not the tg3 module? If that is the case, then that creates problems by not moving with the driver. If that is not the case, all good. Jeff