From: "H. Peter Anvin" <hpa@zytor.com>
To: Bernhard Walle <bwalle@suse.de>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Ying Huang <ying.huang@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: make e820_saved have update from setup_data
Date: Thu, 03 Jul 2008 15:49:31 -0700 [thread overview]
Message-ID: <486D577B.5040705@zytor.com> (raw)
In-Reply-To: <20080703230108.1dbe68cb@kopernikus.site>
Bernhard Walle wrote:
> * Yinghai Lu <yhlu.kernel@gmail.com> [2008-07-03 11:37]:
>> + /* update the e820_saved too */
>> + e820_reserve_setup_data();
>
> Why do you want to update the e820_saved here? /sys/firmware/memmap
> should provide the real BIOS-provided memory map, IMO ...
I would concur with that.
-hpa
next prev parent reply other threads:[~2008-07-03 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 18:35 [PATCH] x86: move saving e820_saved to setup_memory_map Yinghai Lu
2008-07-03 18:37 ` [PATCH] x86: make e820_saved have update from setup_data Yinghai Lu
2008-07-03 21:01 ` Bernhard Walle
2008-07-03 21:32 ` Yinghai Lu
2008-07-03 22:49 ` H. Peter Anvin [this message]
2008-07-03 18:39 ` [PATCH] x86: let early_reserve_e820 update e820_saved too Yinghai Lu
2008-07-09 5:51 ` Ingo Molnar
2008-07-09 5:50 ` [PATCH] x86: move saving e820_saved to setup_memory_map Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486D577B.5040705@zytor.com \
--to=hpa@zytor.com \
--cc=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox