* [PATCH v2] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c
@ 2024-08-29 12:32 Alien Wesley
2024-08-29 18:22 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Alien Wesley @ 2024-08-29 12:32 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel, ~lkcamp/patches
Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.
CHECK: Assignment operator '=' should be on the previous line.
Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
---
v2: Line number removed from subject
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 47f1adf30ab4..2d42e7a5bcdb 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
if ((encoding->flags & IW_ENCODE_DISABLED) ||
ext->alg == IW_ENCODE_ALG_NONE) {
- ieee->pairwise_key_type = ieee->group_key_type
- = KEY_TYPE_NA;
+ ieee->pairwise_key_type = KEY_TYPE_NA;
+ ieee->group_key_type = KEY_TYPE_NA;
rtl92e_cam_reset(dev);
memset(priv->rtllib->swcamtable, 0,
sizeof(struct sw_cam_table) * 32);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c
2024-08-29 12:32 [PATCH v2] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c Alien Wesley
@ 2024-08-29 18:22 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2024-08-29 18:22 UTC (permalink / raw)
To: Alien Wesley, gregkh, linux-staging, linux-kernel,
~lkcamp/patches
On 8/29/24 14:32, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: Assignment operator '=' should be on the previous line.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> v2: Line number removed from subject
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..2d42e7a5bcdb 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
>
> if ((encoding->flags & IW_ENCODE_DISABLED) ||
> ext->alg == IW_ENCODE_ALG_NONE) {
> - ieee->pairwise_key_type = ieee->group_key_type
> - = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-29 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 12:32 [PATCH v2] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c Alien Wesley
2024-08-29 18:22 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox