From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8F2C33CB2 for ; Wed, 29 Jan 2020 05:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59E75214D8 for ; Wed, 29 Jan 2020 05:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbgA2FRn (ORCPT ); Wed, 29 Jan 2020 00:17:43 -0500 Received: from ozlabs.org ([203.11.71.1]:59577 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgA2FRi (ORCPT ); Wed, 29 Jan 2020 00:17:38 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 486sDw3HcXz9sRR; Wed, 29 Jan 2020 16:17:36 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: d80ae83f1f932ab7af47b54d0d3bef4f4dba489f In-Reply-To: <0d894839fdbb19070f0e1e4140363be4f2bb62fc.1578989540.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ptdump: fix W+X verification Message-Id: <486sDw3HcXz9sRR@ozlabs.org> Date: Wed, 29 Jan 2020 16:17:36 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-01-14 at 08:13:09 UTC, Christophe Leroy wrote: > Verification cannot rely on simple bit checking because on some > platforms PAGE_RW is 0, checking that a page is not W means > checking that PAGE_RO is set instead of checking that PAGE_RW > is not set. > > Use pte helpers instead of checking bits. > > Signed-off-by: Christophe Leroy > Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot") Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d80ae83f1f932ab7af47b54d0d3bef4f4dba489f cheers