public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org
Cc: akpm@osdl.org, Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Using __user with compat_uptr_t
Date: Tue, 26 Apr 2005 10:06:12 +0100	[thread overview]
Message-ID: <4872.1114506372@redhat.com> (raw)
In-Reply-To: <20050417033806.65a5786a.sfr@canb.auug.org.au>


Hi Linus,

I've added a couple of structures for dealing with 32-bit -> 64-bit upgrade of
NFS4 mounts. They represent the NFS4 mount information provided by userspace
and they contain some pointers to further userspace data. Should these further
userspace pointers be labelled __user?

For example, is this right?:

	struct compat_nfs_string {
		compat_uint_t len;
		compat_uptr_t __user data;
	};

Or is this right?:

	struct compat_nfs_string {
		compat_uint_t len;
		compat_uptr_t data;
	};

Now it makes no difference to the compiler, but it might affect the checker
tool.

David

  reply	other threads:[~2005-04-26  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-15 14:45 [PATCH] Add 32-bit compatibility for NFSv4 mount David Howells
2005-04-16 17:38 ` Stephen Rothwell
2005-04-26  9:06   ` David Howells [this message]
2005-04-26 14:40     ` Using __user with compat_uptr_t Linus Torvalds
2005-04-27  9:28       ` [PATCH] NFS4: Don't use " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4872.1114506372@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox