From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbcEQJgk (ORCPT ); Tue, 17 May 2016 05:36:40 -0400 Received: from gloria.sntech.de ([95.129.55.99]:34541 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbcEQJgj (ORCPT ); Tue, 17 May 2016 05:36:39 -0400 From: Heiko Stuebner To: Enric Balletbo Serra Cc: Enric Balletbo i Serra , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2 4/5] ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards Date: Tue, 17 May 2016 11:36:23 +0200 Message-ID: <4872705.Eu1B24CGhn@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: References: <1462790795-25345-1-git-send-email-enric.balletbo@collabora.com> <1769207.YFf2RsNhBy@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 17. Mai 2016, 10:14:55 schrieb Enric Balletbo Serra: > Hi Heiko, > > 2016-05-16 0:06 GMT+02:00 Heiko Stuebner : > > Am Montag, 9. Mai 2016, 12:46:34 schrieb Enric Balletbo i Serra: > >> Set i2s block to "okay", add sound node for max98090 with gpios for > >> HP and Mic detect and pinctrl, and add a max98090 device and ts3a227e > >> to > >> the correct i2c bus. > >> > >> Signed-off-by: Enric Balletbo i Serra > > > > I only got a "applied" reply from Marks scripts for patch 3/5, so only > > today saw that all 3 actually got applied. > > > > Anyway, I've applied this to my dts32-branch for 4.8 now [0] with some > > modifications regarding > > - the commit subject+message > > - ordering > > - io_domains access (via the phandle now) > > - regulator suspend property > > so maybe take a look and holler if you see a mistake. > > The changes looks good to me, thanks. > > > I was able to get audio over the headphones (so definitly an > > improvement), but so far not over the built-in speakers. Did you need > > to do something special in the configuration for this? > > I added an UCM file [1] to my setup to test this and tested as follows > (you can also use alsamixer but as you know this is not safe though ;) > ) > > # enable the speaker at bootup: > alsaucm -c ROCKCHIP-I2S set _verb HiFi > # set speaker to half loudness: > amixer set Speaker 50% > # play something > aplay music.wav > # enable headphones (disable speaker): > alsaucm -c ROCKCHIP-I2S set _verb HiFi set _enadev Headphone > # set headphones to half loudness: > amixer set Headphone 50% > # play something > aplay music.wav > # disable headphones (enable speaker): > alsaucm -c ROCKCHIP-I2S set _verb HiFi set _disdev Headphone woohoo ... sound on the speakers :-D Thanks for the hints Heiko