From: "H. Peter Anvin" <hpa@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [0/10] Use 64bit x86 machine check code for 32bit too v2
Date: Mon, 07 Jul 2008 16:53:20 -0700 [thread overview]
Message-ID: <4872AC70.8030704@kernel.org> (raw)
In-Reply-To: <20080708110.487722491@firstfloor.org>
Applied to -tip as x86/unify-mce.
Thanks!
-hpa
Andi Kleen wrote:
> This patchkit uses the 64bit machine check code which is better in many
> ways on 32bit x86 too. This is also the basis for some future machine
> check work.
>
> The 64bit machine check code is in many ways much better than
> the 32bit machine check code: it is more specification compliant,
> is cleaner, only has a single code base versus one per CPU,
> has better infrastructure for recovery, has a cleaner way to communicate
> with user space etc. etc.
>
> It requires testing especially on older systems (on newer
> ones it should be already tested well in 64bit systems).
>
> The patchkit contains several parts:
> - It ports over a few needed quirks (for older Intel and older
> AMD CPUs) to the 64bit kernel.
> - It changes the 64bit code to be 32bit clean in its data structures
> (mostly just unsigned long -> u64 where needed)
> - It drops some unused functionality that cannot be easily implemented on 32bit
> and didn't seem worth ifdefing
>
> Tested by doing some software level error injection on a few
> different machines
>
> I request this code is merged into the appropiate tree for linux-next
> for wider testing. It's not .27 ready, but hopefully .28, but it requires
> wider exposure now.
>
> v2: Fix compilation problems noted by hpa in some configurations
> Fix strict_strtoul() conversion
>
> -Andi
>
next prev parent reply other threads:[~2008-07-07 23:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 23:10 [PATCH] [0/10] Use 64bit x86 machine check code for 32bit too v2 Andi Kleen
2008-07-07 23:10 ` [PATCH] [1/10] MCE: Make 64bit mce code 32bit clean v2 Andi Kleen
2008-07-07 23:10 ` [PATCH] [2/10] MCE: Implement the PPro bank 0 quirk in the 64bit machine check code Andi Kleen
2008-07-07 23:10 ` [PATCH] [3/10] MCE: Port K7 bank 0 quirk to 64bit mce code Andi Kleen
2008-07-07 23:10 ` [PATCH] [4/10] MCE: Call 64bit machine check through a call vector Andi Kleen
2008-07-07 23:10 ` [PATCH] [5/10] MCE: Rename mce_dont_init on 64bit to mce_disabled Andi Kleen
2008-07-07 23:10 ` [PATCH] [6/10] MCE: Provide exit_idle dummy functions for 32bit Andi Kleen
2008-07-07 23:10 ` [PATCH] [7/10] MCE: Remove machine check handler idle notify on 64bit Andi Kleen
2008-07-07 23:10 ` [PATCH] [8/10] MCE: Remove oops_begin() use in 64bit machine check Andi Kleen
2008-07-07 23:10 ` [PATCH] [9/10] Add missing includes in mce_intel_64.c Andi Kleen
2008-07-07 23:10 ` [PATCH] [10/10] MCE: Use 64bit machine check code on 32bit v2 Andi Kleen
2008-07-07 23:53 ` H. Peter Anvin [this message]
2008-07-08 19:54 ` [PATCH] [0/10] Use 64bit x86 machine check code for 32bit too v2 Max Asbock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4872AC70.8030704@kernel.org \
--to=hpa@kernel.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox