From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, libsmbios-devel@lists.us.dell.com,
Srinivas_G_Gowda@dell.com, Michael_E_Brown@dell.com
Subject: Re: [PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight
Date: Thu, 04 Dec 2014 09:50:02 +0100 [thread overview]
Message-ID: <4874352.BarQGyiSH1@xps13> (raw)
In-Reply-To: <20141203084319.GA52608@vmdeb7>
On Wednesday 03 December 2014 00:43:21 Darren Hart wrote:
> > + int kbd_timeouts[];
> >
> > };
> >
> > static struct quirk_entry *quirks;
> >
> > @@ -76,6 +89,10 @@ static int __init dmi_matched(const struct
> > dmi_system_id *dmi)>
> > return 1;
> > }
> >
> >
> > +static struct quirk_entry quirk_dell_xps13_9333 = {
> > + .kbd_timeouts = { 0, 5, 15, 60, 5*60, 15*60, -1 },
>
> Where did these values come from? Were they documented in the
> libsmbios project? Can you provide a URL to that? These really should
> be described by the firmware, but if they aren't, nothing we can do
> about it.
I took those values from a Windows utility provided by Dell. I tried
to find a reason for that specific list to exist, but I couldn't. The
reason why it's there is that the BIOS of my laptop accepts any timeout,
but it silently sets the timeout to 0 (i.e. illumination never off)
if a value not in that list is given. So, given the wide range of
of possible input values, we added that quirk. This is something my
laptop does, Pali's behaves differently and such a list is not needed.
next prev parent reply other threads:[~2014-12-04 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 12:23 [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight Pali Rohár
2014-11-19 18:34 ` Darren Hart
2014-11-19 19:23 ` Matthew Garrett
2014-11-19 19:51 ` Pali Rohár
2014-11-19 19:12 ` Darren Hart
2014-11-19 20:41 ` Pali Rohár
2014-11-21 20:39 ` Darren Hart
2014-11-22 18:46 ` Pali Rohár
2014-11-21 22:09 ` Darren Hart
2014-11-23 14:48 ` Pali Rohár
2014-11-23 14:50 ` [PATCH v2] " Pali Rohár
2014-11-25 23:01 ` Darren Hart
2014-12-01 17:35 ` Pali Rohár
2014-12-03 8:43 ` Darren Hart
2014-12-04 8:50 ` Gabriele Mazzotta [this message]
2014-12-03 11:51 ` Darren Hart
2014-12-05 1:53 ` Pali Rohár
2014-12-04 10:16 ` Pali Rohár
2014-12-03 12:35 ` Darren Hart
2014-12-05 2:03 ` Pali Rohár
2014-12-03 12:49 ` Darren Hart
2014-12-05 11:53 ` [PATCH v3] " Pali Rohár
2014-12-03 18:00 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4874352.BarQGyiSH1@xps13 \
--to=gabriele.mzt@gmail.com \
--cc=Michael_E_Brown@dell.com \
--cc=Srinivas_G_Gowda@dell.com \
--cc=dvhart@infradead.org \
--cc=libsmbios-devel@lists.us.dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox