From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
"mingo@elte.hu" <mingo@elte.hu>, "hpa@zytor.com" <hpa@zytor.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] tip/x86_64: fix e820 merge issue which broke max_pfn_mapped
Date: Wed, 09 Jul 2008 12:03:35 -0700 [thread overview]
Message-ID: <48750B87.70405@goop.org> (raw)
In-Reply-To: <20080709184405.GH1678@linux-os.sc.intel.com>
Suresh Siddha wrote:
> On Wed, Jul 09, 2008 at 11:11:36AM -0700, Jeremy Fitzhardinge wrote:
>
>> Yinghai Lu wrote:
>>
>>> try to reduce #ifdef CONFIG_X86_64/32, and make 32/64 at the same page.
>>>
>>> could be some regression from early_io_remap unifying from jeremy
>>>
>>> please check attached revert patch.
>>>
>> Could my patch "x86_64: there's no need to preallocate
>> level1_fixmap_pgt" be a problem in itself? It seems sound to me, but
>>
>
> Yep. Reverting it made my system with 2GB memory boot fine again.
>
Great. Ingo, would you do the honours of shooting that patch?
>> none of my other code has any functional dependency on it; it's really
>> just cosmetic.
>>
>
> have you test booted it before making this cosmetic change? :)
>
>
Sure, works for me ;)
J
next prev parent reply other threads:[~2008-07-09 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 23:08 [patch] tip/x86_64: fix e820 merge issue which broke max_pfn_mapped Suresh Siddha
2008-07-09 0:47 ` Yinghai Lu
2008-07-09 0:59 ` Yinghai Lu
2008-07-09 1:56 ` Yinghai Lu
2008-07-09 17:56 ` Suresh Siddha
2008-07-09 18:05 ` Yinghai Lu
2008-07-09 18:11 ` Jeremy Fitzhardinge
2008-07-09 18:44 ` Suresh Siddha
2008-07-09 18:47 ` Yinghai Lu
2008-07-09 18:50 ` Suresh Siddha
2008-07-09 18:51 ` Yinghai Lu
2008-07-09 19:03 ` Jeremy Fitzhardinge [this message]
2008-07-09 20:34 ` Ingo Molnar
2008-07-09 18:48 ` Suresh Siddha
2008-07-09 18:59 ` Yinghai Lu
2008-07-09 17:00 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48750B87.70405@goop.org \
--to=jeremy@goop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox