Re: [PATCH] Char: isicom, enable/disable pci device

[Jiri Slaby <jirislaby@gmail.com>]

On 07/11/2008 01:35 AM, Andrew Morton wrote:
> On Thu, 10 Jul 2008 16:20:12 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
>> --- a/drivers/char/isicom.c
>> +++ b/drivers/char/isicom.c
>> @@ -1736,6 +1736,12 @@ static int __devinit isicom_probe(struct pci_dev *pdev,
>>  	if (card_count >= BOARD_COUNT)
>>  		goto err;
>>  
>> +	retval = pci_enable_device(pdev);
>> +	if (retval) {
>> +		dev_err(&pdev->dev, "failed to enable\n");
>> +		goto err;
>> +	}
>> +
[...]
> hm.  Is this a recently-added problem?

It disappeared in 2.6.16 (9ac0948): char/isicom: Pci probing added (by me).

> I wonder what the chance is that this will fix something.  Or break
> something.

This is what pci documentation says:
<cite>
3.1 Enable the PCI device
~~~~~~~~~~~~~~~~~~~~~~~~~
Before touching any device registers, the driver needs to enable
the PCI device by calling pci_enable_device(). This will:
         o wake up the device if it was in suspended state,
         o allocate I/O and memory regions of the device (if BIOS did not),
         o allocate an IRQ (if BIOS did not).
</cite>
Maybe Jesse can tell us more on what effect might have device enable omitting?