Re: 回复: 回复: 回复: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/08/2025 12:18, Gary Yang wrote:
>>>
>>> So you see the twice, once per one pin-controller. BTW as you suggested
>> before, we will print the value of ret in the error message.
>>>
>>> If I miss any information, please kindly remind me. Thanks
>>
>> You still ignored my second comment.

^^^ That was second time here I reminded about ENOMEM comment.

>>
> 
> First you wrote " You are printing same error twice ", please pay attention to the "same error" strings, it makes me confuse, I misunderstand your thinking 
> until you took the example above. So the discussion is needed, not waste our time.
> 
> Second the return value of sky1_pinctrl_probe_dt() is not only ENOMEM, it can also return ENODEV and EINVAL. Although I don't think this is a bug, take our

The problem is that you ignored the ENOMEM comment and it clearly should
direct you to the problem and solution ("If I cannot have error on
ENOMEM, I will move my error msgs to the called function").

Best regards,
Krzysztof