Re: [PATCH 3/3] Add timeout feature

Ric Wheeler
2008-09-25T21:07:10Z

Christoph Hellwig wrote:
> On Mon, Sep 08, 2008 at 08:53:37PM +0900, Takashi Sato wrote:
>
>> The timeout feature is added to "freeze ioctl" to solve a deadlock
>> when the freezer accesses a frozen filesystem. And new ioctl
>> to reset the timeout period is added to extend the timeout period.
>> For example, the freezer resets the timeout period to 10 seconds every 5
>> seconds. In this approach, even if the freezer causes a deadlock by
>> accessing the frozen filesystem, it will be solved by the timeout
>> in 10 seconds and the freezer will be able to recognize that
>> at the next reset of timeout period.
>>
>
> And as with all previous posting I still fundamentally disagree about
> the need of this functionality. We don't need a timeout for freezing.
>
>

I agree with Christoph here, I think that the timeout is unneeded.

Regards,

Ric