From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Jakub W. Jozwicki" <jozwicki@aster.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@timesys.com
Subject: Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic
Date: Sun, 13 Jul 2008 10:46:29 -0700 [thread overview]
Message-ID: <487A3F75.5010405@goop.org> (raw)
In-Reply-To: <200807131517.51795.jozwicki@aster.pl>
Jakub W. Jozwicki wrote:
>
> Sorry, this was for -rt only.
>
> [ 17.012011] BUG: sleeping function called from invalid context IRQ-14(5732)
> at arch/x86/mm/highmem_32.c:8
> [ 17.012011] in_atomic():0 [00000000], irqs_disabled():1
> [ 17.012011] Pid: 5732, comm: IRQ-14 Not tainted 2.6.25.10-rtXXX #11
> [ 17.012011] [<c0120fc4>] __might_sleep+0xf1/0xf8
> [ 17.012011] [<c011c035>] kmap+0x47/0x5a
>
The subject says kmap_atomic, but this is kmap. It definitely makes no
sense to call kmap in an IRQ, regardless of the locking. There seems to
be a larger structural problem here.
> [ 17.012011] [<c033e728>] ata_hsm_move+0x3d7/0x657
> [ 17.012011] [<c0342fd6>] ata_interrupt+0x14e/0x1cb
> [ 17.012011] [<c015c72c>] handle_IRQ_event+0x4e/0xd1
> [ 17.012011] [<c015d266>] do_irqd+0x126/0x224
> [ 17.012011] [<c015d140>] ? do_irqd+0x0/0x224
> [ 17.012011] [<c013ae9d>] kthread+0x3b/0x62
> [ 17.012011] [<c013ae62>] ? kthread+0x0/0x62
> [ 17.012011] [<c0108287>] kernel_thread_helper+0x7/0x10
> [ 17.012011] =======================
>
J
next prev parent reply other threads:[~2008-07-13 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 23:27 [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic Jakub W. Jozwicki
2008-07-13 8:26 ` Andrew Morton
2008-07-13 13:17 ` Jakub W. Jozwicki
2008-07-13 17:46 ` Jeremy Fitzhardinge [this message]
2008-07-13 18:53 ` Jakub W. Jozwicki
2008-07-13 21:32 ` Jeremy Fitzhardinge
2008-07-13 10:25 ` Alan Cox
2008-07-13 13:30 ` Jakub W. Jozwicki
2008-07-13 14:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487A3F75.5010405@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=jozwicki@aster.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox