From: Jes Sorensen <jes@sgi.com>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies <kernelnewbies@nl.linux.org>,
linux-scsi@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH] qla1280: use request_firmware
Date: Mon, 14 Jul 2008 11:29:23 +0200 [thread overview]
Message-ID: <487B1C73.5000202@sgi.com> (raw)
In-Reply-To: <1215770284.2733.10.camel@jaswinder.satnam>
Jaswinder Singh wrote:
> this is a first draft; please be kind :)
>
> Firmware blob is little endian looks like this...
> unsigned char Version1
> unsigned char Version2
> unsigned char Version3
> unsigned char Padding
> unsigned short start_address
> unsigned short data
Hello,
As the maintainer of this driver I am going to say that I think this is
a stupid change. Yes I know that politically there's a move to make
everything use request firmware. However for my boot device, this is
going to be a royal pain in the butt for developers who wish to boot
test kernels with a / sitting on a 1280.
IMHO this patch brings us nothing, but provides a lot of unnecessary
hassle for users.
Nacked-By: Jes Sorensen <jes@sgi.com>
Regards,
Jes
next parent reply other threads:[~2008-07-14 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1215770284.2733.10.camel@jaswinder.satnam>
2008-07-14 9:29 ` Jes Sorensen [this message]
2008-07-14 12:38 ` [PATCH] qla1280: use request_firmware Jaswinder Singh
2008-07-14 14:03 ` Jes Sorensen
2008-07-14 13:59 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487B1C73.5000202@sgi.com \
--to=jes@sgi.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=jaswinder@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox