public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: ia32_signal.c: use macro instead of immediate
Date: Mon, 14 Jul 2008 15:05:16 -0700	[thread overview]
Message-ID: <487BCD9C.4030003@zytor.com> (raw)
In-Reply-To: <487BC1B9.1090400@ct.jp.nec.com>

Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> 
> Make and use macro FIX_EFLAGS, instead of immediate value 0x40DD5 in
> ia32_restore_sigcontext().
> 
> +
> +#ifdef CONFIG_X86_32
> +# define FIX_EFLAGS	(__FIX_EFLAGS | X86_EFLAGS_RF)
> +#else
> +# define FIX_EFLAGS	__FIX_EFLAGS
> +#endif
> +

Where did this come from?  First of all, this is in a 64-bit-only file, 
so CONFIG_X86_32 will never be set; second of all, it seems a bit fishy 
that these should be different.

	-hpa

  reply	other threads:[~2008-07-14 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 21:14 [PATCH] x86_64: ia32_signal.c: use macro instead of immediate Hiroshi Shimamoto
2008-07-14 22:05 ` H. Peter Anvin [this message]
2008-07-14 22:19   ` Hiroshi Shimamoto
2008-07-14 22:23     ` H. Peter Anvin
2008-07-14 22:26       ` Hiroshi Shimamoto
2008-07-14 22:34       ` Hiroshi Shimamoto
2008-07-18 11:53         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487BCD9C.4030003@zytor.com \
    --to=hpa@zytor.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox